Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential passing of NoneType to remove_ansi_escape #4882

Merged
merged 9 commits into from
Jul 7, 2023
Merged

Fix potential passing of NoneType to remove_ansi_escape #4882

merged 9 commits into from
Jul 7, 2023

Conversation

u007
Copy link
Contributor

@u007 u007 commented Jul 4, 2023

seems to be a logging issue

@github-actions github-actions bot added the size/m label Jul 4, 2023
This was referenced Jul 4, 2023
Merged
Closed
@lc0rp lc0rp added this to the v0.4.4 Release milestone Jul 4, 2023
lc0rp
lc0rp reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@lc0rp lc0rp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you pair it w/ a unit test?

@lc0rp lc0rp added bug Something isn't working hotfix labels Jul 4, 2023
@lc0rp lc0rp self-assigned this Jul 4, 2023
@Pwuts Pwuts changed the base branch from stable to master July 4, 2023 13:30
@netlify
Copy link

netlify bot commented Jul 4, 2023 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 80714b2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a74f57d1d54c00077e51fd

@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6893b7e) 50.05% compared to head (80714b2) 50.05%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4882   +/-   ##
=======================================
  Coverage   50.05%   50.05%           
=======================================
  Files         116      116           
  Lines        4799     4799           
  Branches      643      643           
=======================================
  Hits         2402     2402           
  Misses       2218     2218           
  Partials      179      179
Impacted Files Coverage Δ
autogpt/logs.py 73.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Pwuts
Pwuts requested changes Jul 4, 2023
View reviewed changes
autogpt/logs.py Outdated Show resolved Hide resolved
autogpt/logs.py Outdated Show resolved Hide resolved
@Pwuts Pwuts changed the title fix replace of nonetype Fix potential passing of NoneType to remove_ansi_escape Jul 4, 2023
@github-actions github-actions bot added size/s and removed size/m labels Jul 4, 2023
@u007 u007 changed the title Fix potential passing of NoneType to remove_ansi_escape [wip] Fix potential passing of NoneType to remove_ansi_escape Jul 5, 2023
@u007 u007 changed the title [wip] Fix potential passing of NoneType to remove_ansi_escape Fix potential passing of NoneType to remove_ansi_escape Jul 5, 2023
@Pwuts Pwuts linked an issue Jul 6, 2023 that may be closed by this pull request
OPENAI_FUNCTIONS 'NoneType' object has no attribute 'replace' #4845
Closed
1 task
@Pwuts
Copy link
Member

Pwuts commented Jul 6, 2023

Note that this PR doesn't fix the instance reported in #4845:

  File "C:\Users\Zachary\Documents\Personal_Projects\autogpt\auto-gpt_git\Auto-GPT\autogpt\agent\agent.py", line 188, in start_interaction_loop
    f"COMMAND = {Fore.CYAN}{remove_ansi_escape(command_name)}{Style.RESET_ALL}  "
  File "C:\Users\Zachary\Documents\Personal_Projects\autogpt\auto-gpt_git\Auto-GPT\autogpt\logs.py", line 253, in remove_ansi_escape
    return s.replace("\x1B", "") AttributeError: 'NoneType' object has no attribute 'replace'

@lc0rp lc0rp merged commit e4a337f into Significant-Gravitas:master Jul 7, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
@u007 @Pwuts @lc0rp
Fix potential passing of NoneType to remove_ansi_escape (Significant-…
4abe82d 
…Gravitas#4882)

Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Luke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lc0rp lc0rp lc0rp left review comments

@Pwuts Pwuts Pwuts approved these changes

Assignees

@lc0rp lc0rp

Labels
bug Something isn't working hotfix size/s
Projects
AutoGPT development kanban
Archived in project
Milestone
v0.4.4 Release
Development

Successfully merging this pull request may close these issues.

OPENAI_FUNCTIONS 'NoneType' object has no attribute 'replace'
3 participants
@u007 @Pwuts @lc0rp