Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: summarize_text function usage #4863

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

VenkatTeja
Copy link
Contributor

Background

Incorrect usage of summarize_text function within recursion

Changes

Update the parameters passed to summarize_text function i.e. add config param

Documentation

Not required

Test Plan

No changes

PR Quality Checklist

  • [✅] My pull request is atomic and focuses on a single change.
  • [✅] I have thoroughly tested my changes with multiple different prompts.
  • [✅ ] I have considered potential risks and mitigations for my changes.
  • [✅] I have documented my changes clearly and comprehensively.
  • [✅] I have not snuck in any "extra" small tweaks changes.
  • [✅] I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 5d49557
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a79998da956100095816ea
😎 Deploy Preview https://deploy-preview-4863--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the size/s label Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b7e101) 50.03% compared to head (5d49557) 50.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4863   +/-   ##
=======================================
  Coverage   50.03%   50.03%           
=======================================
  Files         116      116           
  Lines        4831     4831           
  Branches      650      650           
=======================================
  Hits         2417     2417           
  Misses       2229     2229           
  Partials      185      185           
Impacted Files Coverage Δ
autogpt/memory/vector/memory_item.py 86.36% <ø> (ø)
autogpt/processing/text.py 33.96% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically a duplicate of #4876, but more complete and raised to master this time. LGTM!

@Pwuts Pwuts added this to the v0.4.5 Release milestone Jul 7, 2023
@Pwuts Pwuts merged commit 0f538f6 into Significant-Gravitas:master Jul 7, 2023
@lc0rp lc0rp modified the milestones: v0.4.5 Release, v0.4.4 Release Jul 8, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
* Fix summarize_text function usage

* Update memory_item.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Command browse_website returned: Error: 'str' object has no attribute 'fast_llm_model'
3 participants