Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering out ANSI escape codes in printed assistant thoughts #4810

Merged
merged 6 commits into from
Jun 27, 2023
Merged

Filtering out ANSI escape codes in printed assistant thoughts #4810

merged 6 commits into from
Jun 27, 2023

Conversation

lukas-eu
Copy link
Contributor

@lukas-eu lukas-eu commented Jun 27, 2023 •
edited
Loading

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters: 
    black .
isort .
mypy
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit b1ecf85
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/649b0068cea548000843e609

@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (9f353f4) 70.96% compared to head (2eb0296) 70.98%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4810      +/-   ##
==========================================
+ Coverage   70.96%   70.98%   +0.01%     
==========================================
  Files          69       69              
  Lines        3348     3350       +2     
  Branches      542      542              
==========================================
+ Hits         2376     2378       +2     
  Misses        794      794              
  Partials      178      178
Impacted Files Coverage Δ
autogpt/agent/agent.py 58.90% <100.00%> (ø)
autogpt/logs.py 74.54% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lc0rp lc0rp mentioned this pull request Jun 27, 2023
Merged
@lc0rp lc0rp added this to the v0.4.3 Release milestone Jun 27, 2023
@lc0rp lc0rp merged commit bafcdce into Significant-Gravitas:master Jun 27, 2023
lc0rp pushed a commit to lc0rp/Auto-GPT-Turbo that referenced this pull request Jul 1, 2023
@lukas-eu @lc0rp
Filtering out ANSI escape codes in printed assistant thoughts (Signif…
9ba25db 
…icant-Gravitas#4810)

Co-authored-by: merwanehamadi <[email protected]>
Co-authored-by: Luke K (pr-0f3t) <[email protected]>
(cherry picked from commit bafcdce)
(cherry picked from commit b69816823c34ac4c2ef141dc8ec195f55636eff6)
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
@lukas-eu @waynehamadi @lc0rp
Filtering out ANSI escape codes in printed assistant thoughts (Signif…
8fa0fc1 
…icant-Gravitas#4810)

Co-authored-by: merwanehamadi <[email protected]>
Co-authored-by: Luke K (pr-0f3t) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle approved these changes

Assignees
No one assigned
Labels
size/m
Projects
AutoGPT development kanban
Archived in project
Milestone
v0.4.3 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@lukas-eu @ntindle @lc0rp @waynehamadi