-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link all challenges to benchmark python hook #4786
Link all challenges to benchmark python hook #4786
Conversation
✅ Deploy Preview for auto-gpt-docs canceled.
|
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
7b82eb2
to
15a0d2a
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4786 +/- ##
==========================================
+ Coverage 70.71% 70.77% +0.06%
==========================================
Files 68 68
Lines 3326 3326
Branches 532 532
==========================================
+ Hits 2352 2354 +2
+ Misses 796 795 -1
+ Partials 178 177 -1 ☔ View full report in Codecov by Sentry. |
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
patched_api_requestor: None, | ||
monkeypatch: pytest.MonkeyPatch, | ||
level_to_run: int, | ||
challenge_name: str, | ||
workspace: Workspace, | ||
patched_make_workspace: pytest.fixture, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid type, and definitely not the return type of that fixture. It contains an empty yield
statement, so the correct type here would be None
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you enabled type checking in your IDE? Might help to prevent this kind of errors.
Background
Currently there is only one challenge linked to the benchmarks.py file. We need all the challenges linked to this benchmarks.py
Changes
Documentation
Test Plan
PR Quality Checklist