Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON errors more silent #4748

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Jun 20, 2023

Background

The JSON invalid error is a giant red error everyone sees even witout the debug flag

Changes

Make JSON errors more silent by using debug instead of error.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit f237fbd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6491af62cff7d70008279d31
😎 Deploy Preview https://deploy-preview-4748--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4e3f832) 70.63% compared to head (f237fbd) 70.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4748   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files          67       67           
  Lines        3238     3238           
  Branches      513      513           
=======================================
  Hits         2287     2287           
  Misses        783      783           
  Partials      168      168           
Impacted Files Coverage Δ
autogpt/json_utils/utilities.py 74.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi merged commit e5d6206 into Significant-Gravitas:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants