Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execute_command coming from plugins #4729

Merged

Conversation

erik-megarad
Copy link
Contributor

@erik-megarad erik-megarad commented Jun 17, 2023

Background

There was a regression introduced recently for plugins. Issue Significant-Gravitas/Auto-GPT-Plugins#202

Changes

Fix the plugin issue by changing the args to the execute_command function

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit a725520
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/648e29f5382f8f0008ceabb1

waynehamadi
waynehamadi previously approved these changes Jun 17, 2023
@Auto-GPT-Bot Auto-GPT-Bot force-pushed the fix/plugin_command branch 3 times, most recently from feb00e5 to 4c11b14 Compare June 17, 2023 21:10
waynehamadi
waynehamadi previously approved these changes Jun 17, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 80.95% and project coverage change: -0.18 ⚠️

Comparison is base (0b6fec4) 71.32% compared to head (a725520) 71.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4729      +/-   ##
==========================================
- Coverage   71.32%   71.14%   -0.18%     
==========================================
  Files          68       68              
  Lines        3309     3251      -58     
  Branches      528      516      -12     
==========================================
- Hits         2360     2313      -47     
+ Misses        787      775      -12     
- Partials      162      163       +1     
Impacted Files Coverage Δ
autogpt/agent/agent.py 58.90% <ø> (ø)
autogpt/commands/git_operations.py 100.00% <ø> (ø)
autogpt/commands/image_gen.py 75.67% <ø> (ø)
autogpt/commands/task_statuses.py 100.00% <ø> (ø)
autogpt/commands/web_selenium.py 54.20% <ø> (ø)
autogpt/main.py 22.07% <ø> (ø)
autogpt/app.py 48.88% <50.00%> (+11.93%) ⬆️
autogpt/plugins/__init__.py 79.35% <70.00%> (-1.32%) ⬇️
autogpt/command_decorator.py 95.65% <100.00%> (ø)
autogpt/commands/execute_code.py 73.52% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi changed the base branch from master to Release-v0.4.1 June 17, 2023 21:17
@erik-megarad erik-megarad changed the base branch from Release-v0.4.1 to master June 17, 2023 21:25
@erik-megarad erik-megarad dismissed waynehamadi’s stale review June 17, 2023 21:25

The base branch was changed.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@lc0rp lc0rp changed the base branch from master to Release-v0.4.1 June 17, 2023 21:46
@waynehamadi waynehamadi changed the base branch from Release-v0.4.1 to master June 17, 2023 21:46
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 17, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@waynehamadi waynehamadi merged commit 096d27f into Significant-Gravitas:master Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants