Improve plugin backward compatibility #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynehamadi
pushed a commit
to waynehamadi/Auto-GPT
that referenced
this pull request
Jun 17, 2023
waynehamadi
pushed a commit
to waynehamadi/Auto-GPT
that referenced
this pull request
Jun 17, 2023
waynehamadi
added a commit
that referenced
this pull request
Jun 17, 2023
* Use JSON for command signature Signed-off-by: Merwane Hamadi <[email protected]> * Improve plugin backward compatibility (#4716) * Fixed plugin test Signed-off-by: Merwane Hamadi <[email protected]> * Fix Docker-CI Signed-off-by: Merwane Hamadi <[email protected]> * Put back commands, clean typing and signatures Signed-off-by: Merwane Hamadi <[email protected]> --------- Signed-off-by: Merwane Hamadi <[email protected]> Co-authored-by: Erik Peterson <[email protected]> Co-authored-by: Luke K (pr-0f3t) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Legacy zipped plugins don't load on 0.4.1, and instead emit a "plugin not configured" warning. The reason appears to be the move from class-based config keys to directory-based config keys.
This PR enables class-based config keys for zipped plugins, which allows legacy plugins to load.
Changes
Updated the code that checks whether a zipped plugin is configured to do so within the plugin load loop, where the class name is available, and updated the emitted debug and warning logs.
Documentation
No change to docs as this is the legacy behavior.
PR Quality Checklist