Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write_tests and improve_code #4707

Merged

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Jun 15, 2023

Background

Remove write_tests and improve_code.
Unfortunately browse_website is flaky so I removed the score

Changes

Remove write_tests and improve_code.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@github-actions github-actions bot added size/m conflicts Automatically applied to PRs with merge conflicts labels Jun 15, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 38bcea1
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/648b72653796e40008886e4d

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 15, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/s and removed size/m labels Jun 15, 2023
@waynehamadi waynehamadi force-pushed the remove-write-tests branch 2 times, most recently from 13d3fac to 97604c1 Compare June 15, 2023 19:58
@github-actions github-actions bot added size/m and removed size/s labels Jun 15, 2023
Signed-off-by: Merwane Hamadi <[email protected]>
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.18 ⚠️

Comparison is base (512d7ba) 71.41% compared to head (38bcea1) 70.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4707      +/-   ##
==========================================
- Coverage   71.41%   70.23%   -1.18%     
==========================================
  Files          73       71       -2     
  Lines        3526     3504      -22     
  Branches      561      561              
==========================================
- Hits         2518     2461      -57     
- Misses        836      872      +36     
+ Partials      172      171       -1     
Impacted Files Coverage Δ
autogpt/main.py 22.07% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi merged commit a30e5a8 into Significant-Gravitas:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants