Implement loading MemoryItem
s from file in JSONFileMemory
#4703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
JSONFileMemory
will write memories to a file, but can't yet load them back from a file. This PR fixes that.Changes
MemoryItem
s from JSON index fileinit
param fromget_memory()
, replace usages bymemory.clear()
MemoryItem.dump()
Documentation
x
Test Plan
I added a test for
JSONFileMemory.load_index()
, so if CI is green we're goodPR Quality Checklist