-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass config everywhere in order to get rid of singleton #4666
Pass config everywhere in order to get rid of singleton #4666
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
f101cc8
to
8cec413
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to sound insane but rename all variables that you update to be passed configs to config
from cfg
so that they’re easier to identify separately
8cec413
to
446cfca
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
446cfca
to
0c1d57d
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
0c1d57d
to
99da272
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4666 +/- ##
==========================================
- Coverage 71.32% 71.12% -0.20%
==========================================
Files 68 68
Lines 3309 3235 -74
Branches 528 516 -12
==========================================
- Hits 2360 2301 -59
+ Misses 787 771 -16
- Partials 162 163 +1
☔ View full report in Codecov by Sentry. |
f4fa70a
to
76597c1
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
76597c1
to
3100d93
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
3100d93
to
1481737
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
1481737
to
dcc5634
Compare
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
dcc5634
to
15763d8
Compare
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
15763d8
to
5dc5467
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
5dc5467
to
2a4f291
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
2a4f291
to
997f063
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
997f063
to
5612d68
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
5612d68
to
5d41c96
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
Signed-off-by: Merwane Hamadi <[email protected]>
5d41c96
to
ab0075b
Compare
This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR. |
Background
Pass config everywhere in order to get rid of singleton
Changes
Documentation
Test Plan
PR Quality Checklist