Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "debug code" challenge #4632

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Jun 9, 2023

Background

The debug code challenge was flaky.

Changes

  • Debug code Challenge is now not flaky at level 1.
  • Level 2 is flaky.
  • Level 3 is never passing
  • some code cleanup

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 9, 2023 3:05pm

@github-actions github-actions bot added the size/l label Jun 9, 2023
@waynehamadi waynehamadi marked this pull request as draft June 9, 2023 12:53
@waynehamadi waynehamadi force-pushed the fix-debug-code-challenge branch from 55f08fe to 4c5175d Compare June 9, 2023 13:03
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (3b0d49a) 69.67% compared to head (dcce9e1) 69.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4632      +/-   ##
==========================================
+ Coverage   69.67%   69.73%   +0.05%     
==========================================
  Files          72       72              
  Lines        3558     3558              
  Branches      569      569              
==========================================
+ Hits         2479     2481       +2     
+ Misses        890      889       -1     
+ Partials      189      188       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi force-pushed the fix-debug-code-challenge branch from 4c5175d to ca31912 Compare June 9, 2023 14:35
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 9, 2023
@waynehamadi waynehamadi force-pushed the fix-debug-code-challenge branch from ca31912 to dcce9e1 Compare June 9, 2023 15:05
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@waynehamadi waynehamadi marked this pull request as ready for review June 9, 2023 15:09
Copy link

@ai-maintainer-bot ai-maintainer-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Glad to hear it isn't flaky anymore :)

Copy link
Contributor

@dschonholtz dschonholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that bot sure is good at reviews. I approve too

@waynehamadi waynehamadi merged commit 12ed5a9 into Significant-Gravitas:master Jun 9, 2023
lc0rp added a commit that referenced this pull request Jun 19, 2023
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: k-boikov <[email protected]>
Co-authored-by: merwanehamadi <[email protected]>
Co-authored-by: Merwane Hamadi <[email protected]>
Co-authored-by: Richard Beales <[email protected]>
Co-authored-by: Luke K <[email protected]>
Co-authored-by: Luke K (pr-0f3t) <[email protected]>
Co-authored-by: Erik Peterson <[email protected]>
Co-authored-by: Auto-GPT-Bot <[email protected]>
Co-authored-by: Benny van der Lans <[email protected]>
Co-authored-by: Jan <[email protected]>
Co-authored-by: Robin Richtsfeld <[email protected]>
Co-authored-by: Marc Bornträger <[email protected]>
Co-authored-by: Stefan Ayala <[email protected]>
Co-authored-by: javableu <[email protected]>
Co-authored-by: DGdev91 <[email protected]>
Co-authored-by: Kinance <[email protected]>
Co-authored-by: digger yu <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: gravelBridge <[email protected]>
Fix Python CI "update cassettes" step (#4591)
fix CI (#4596)
Fix inverted logic for deny_command (#4563)
fix current_score.json generation (#4601)
Fix duckduckgo rate limiting (#4592)
Fix debug code challenge (#4632)
Fix issues with information retrieval challenge a (#4622)
fix issues with env configuration and .env.template (#4630)
Fix prompt issue causing 'No Command' issues and challenge to fail (#4623)
Fix benchmark logs (#4653)
Fix typo in docs/setup.md (#4613)
Fix run.sh shebang (#4561)
Fix autogpt docker image not working because missing prompt_settings (#4680)
Fix execute_command coming from plugins (#4730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants