Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #4610

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Update .gitignore #4610

merged 2 commits into from
Jun 7, 2023

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Jun 7, 2023

Background

Gitignore updates missed a setting for the workspaces folder

Changes

Fixes the Ignore for the workspace

Documentation

N/A

Test Plan

Tested locally

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 7, 2023

Deployment failed with the following error:

Resource is limited - try again in 8 hours (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added the size/s label Jun 7, 2023
@ntindle ntindle added this to the v0.4.1 Release milestone Jun 7, 2023
@ntindle ntindle requested a review from a team June 7, 2023 05:48
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9f1f05) 69.70% compared to head (e7f494a) 69.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4610   +/-   ##
=======================================
  Coverage   69.70%   69.70%           
=======================================
  Files          72       72           
  Lines        3562     3562           
  Branches      569      569           
=======================================
  Hits         2483     2483           
  Misses        890      890           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record:
Instead of merging this I'd rather address the problem of the workspace folder wandering around. It's not supposed to be in autogpt/. That is the folder containing the program source and nothing else. It's not the first time that the workspace folder accidentally moved in there either; this has happened multiple times, usually caused by a relative reference to the workspace path being moved to a file that is one level deeper in autogpt/.

@ntindle ntindle merged commit dae58f8 into master Jun 7, 2023
@ntindle ntindle deleted the fix/gitignore branch June 7, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants