Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for internal PRs with CI changes #4552

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Fix CI for internal PRs with CI changes #4552

merged 3 commits into from
Jun 2, 2023

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jun 2, 2023 •
edited
Loading

Background

CI currently breaks quite easily because we use pull_request_target: https://github.com/Significant-Gravitas/Auto-GPT/actions/runs/5154842393/jobs/9287034366#logs

Changes

  • Use pull_request instead of pull_request_target for internal pull requests
  • Clean up CI workflow
  • Fix git authentication set-up

Test Plan

See checks below: since this is an internal PR, the CI runs on pull_request. For PRs from forks, it should still run on pull_request_target.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 2, 2023 7:01pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@Pwuts Pwuts changed the base branch from master to release-0.4.0 June 2, 2023 18:49
@Pwuts Pwuts requested a review from ntindle June 2, 2023 18:53
@github-actions github-actions bot added size/l and removed size/xl labels Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (3d494f1) 60.72% compared to head (82cbcaf) 60.72%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           stable    #4552   +/-   ##
=======================================
  Coverage   60.72%   60.72%           
=======================================
  Files          73       73           
  Lines        3320     3320           
  Branches      475      475           
=======================================
  Hits         2016     2016           
  Misses       1164     1164           
  Partials      140      140

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts changed the base branch from release-0.4.0 to stable June 2, 2023 19:02
@github-actions github-actions bot added size/xl and removed size/l labels Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@Pwuts Pwuts changed the base branch from stable to master June 2, 2023 19:02
@vercel
Copy link

vercel bot commented Jun 2, 2023

Deployment failed with the following error:

Resource is limited - try again in 4 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@vercel
Copy link

vercel bot commented Jun 2, 2023

Deployment failed with the following error:

Resource is limited - try again in 8 minutes (more than 100, code: "api-deployments-free-per-day").

@Pwuts Pwuts changed the base branch from master to stable June 2, 2023 19:12
@github-actions github-actions bot added size/l and removed size/xl labels Jun 2, 2023
@vercel
Copy link

vercel bot commented Jun 2, 2023

Deployment failed with the following error:

Resource is limited - try again in 26 seconds (more than 100, code: "api-deployments-free-per-day").

ntindle
ntindle approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move all of these into a scripts folder for ci

.github/workflows/ci.yml
if [[ "${{ steps.push_cassettes.outputs.updated }}" == "true" ]]; then
echo "Adding label and comment..."
curl -X POST \
-H "Authorization: Bearer $TOKEN" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t save token to a var? Just use it directly? Also does this log?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's scrubbed from the log because it's a secret

@waynehamadi waynehamadi merged commit 9247f94 into stable Jun 2, 2023
@waynehamadi waynehamadi deleted the fix-ci branch June 2, 2023 20:49
kuwork added a commit to kuwork/Auto-GPT that referenced this pull request Jun 12, 2023
@kuwork
Merge branch 'cn-dev' into cn
7dbedd3 
* cn-dev: (64 commits)
  针对国内的情况，翻译成中文
  Update challenge scores
  Update version numbers for v0.4.0 release
  Add `replace_in_file` command (Significant-Gravitas#4565)
  Update bulletin with highlights for v0.4.0 release (Significant-Gravitas#4576)
  Skip flaky challenges (Significant-Gravitas#4573)
  Fix `test_web_selenium` (Significant-Gravitas#4554)
  Clean up CI git logic
  remove information retrieval challenge b from beaten challenges
  Fix CI git authentication and cassettes
  debug
  Fix CI git diff
  Fix CI git authorization
  Update submodule reference
  Update current score
  Cache Python Packages in the CI pipeline (Significant-Gravitas#4488)
  Fix pushing cassettes in CI
  Remove news about config (Significant-Gravitas#4553)
  Fix CI for internal PRs with CI changes (Significant-Gravitas#4552)
  Update BULLETIN.md
  ...

# Conflicts:
#	BULLETIN.md
#	CONTRIBUTING.md
#	autogpt/agent/agent.py
#	autogpt/app.py
#	autogpt/llm/llm_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynehamadi waynehamadi waynehamadi approved these changes

@ntindle ntindle ntindle approved these changes

@richbeales richbeales richbeales approved these changes

Assignees
No one assigned
Labels
behaviour change size/l
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pwuts @Auto-GPT-Bot @richbeales @ntindle @waynehamadi