Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make challenge "write file" harder + add level 2 #4481

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Make challenge "write file" harder + add level 2 #4481

merged 3 commits into from
Jun 9, 2023

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented May 30, 2023 •
edited
Loading

Background

Changes

  • Now the test to write file uses the default commands, and gives less hints regarding what to do.
  • the level asks to write 2 files in only 1 cycle, which will require AutoGPT's code to change.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters: 
    black .
isort .
mypy
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports autogpt tests --in-place

@vercel
Copy link

vercel bot commented May 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 9, 2023 2:44pm

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi marked this pull request as draft May 30, 2023 16:16
@waynehamadi waynehamadi force-pushed the make-test-write-file-harder branch from 3886d2d to fd91b0c Compare May 30, 2023 16:29
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd2e26a) 69.67% compared to head (2b53083) 69.67%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4481   +/-   ##
=======================================
  Coverage   69.67%   69.67%           
=======================================
  Files          72       72           
  Lines        3558     3558           
  Branches      569      569           
=======================================
  Hits         2479     2479           
  Misses        890      890           
  Partials      189      189

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 30, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@waynehamadi waynehamadi changed the title Make test write file harder + add level 2 Make information retrieval challenge harder + add level 2 and 3 May 31, 2023
@waynehamadi waynehamadi changed the title Make information retrieval challenge harder + add level 2 and 3 Make challenge "write file" harder + add level 2 and 3 May 31, 2023
@waynehamadi waynehamadi changed the title Make challenge "write file" harder + add level 2 and 3 Make challenge "write file" harder + add level 2 May 31, 2023
@waynehamadi waynehamadi force-pushed the make-test-write-file-harder branch from fd91b0c to 095409a Compare May 31, 2023 18:57
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 31, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/l and removed size/xl labels May 31, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@waynehamadi waynehamadi force-pushed the make-test-write-file-harder branch from 095409a to cc59ec6 Compare June 8, 2023 00:09
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@waynehamadi waynehamadi marked this pull request as ready for review June 8, 2023 00:12
@waynehamadi waynehamadi merged commit 3b0d49a into Significant-Gravitas:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-boikov k-boikov k-boikov approved these changes

@erik-megarad erik-megarad erik-megarad approved these changes

Assignees
No one assigned
Labels
behaviour change size/l
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waynehamadi @Auto-GPT-Bot @erik-megarad @k-boikov