-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4461: Don't record error requests in challenges #4469
Fix #4461: Don't record error requests in challenges #4469
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
c7481a7
to
e7fea50
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4469 +/- ##
=======================================
Coverage 68.57% 68.57%
=======================================
Files 72 72
Lines 3520 3520
Branches 561 561
=======================================
Hits 2414 2414
Misses 921 921
Partials 185 185 ☔ View full report in Codecov by Sentry. |
@erik-megarad I will add that change, there is some adjustment to make thank you very much ! |
c0c80d1
to
1d8f934
Compare
Set my usage limit in OpenAI to 1 => love this |
@erik-megarad you're on discord ? If not join us: |
1d8f934
to
e7fea50
Compare
Background
As described in #4461, we don't want VCR to record error responses (e.g. quota limit errors) when recording challenges. This PR will filter error requests for challenges only.
Changes
Documentation
Test Plan
PR Quality Checklist