Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create "Debug Code Challenge" #4286

Merged
merged 1 commit into from
May 30, 2023
Merged

Create "Debug Code Challenge" #4286

merged 1 commit into from
May 30, 2023

Conversation

dschonholtz
Copy link
Contributor

@dschonholtz dschonholtz commented May 18, 2023 •
edited
Loading

Background

Changes

  • Moves the code to be executed and tests to their own files
  • Uses our self hosted fork of vcrpy
  • Appears to work! (The first time)
  • In order to support this new fork, we have to remove vcrpy and install it as new urls do not trigger a re-install in requirements.txt and update/re-install flags do not work there.
  • Because of this bulletin update, I also added in the bulletin for @p-i- for version 0.3.1

Documentation

  • Code comments throughout.
  • Bulletin update explaining the breaking challenge change.

Test Plan

  • This is a test :)

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run black . and isort . against my code to ensure it passes our linter.

@vercel
Copy link

vercel bot commented May 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2023 11:06pm

@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts size/l labels May 18, 2023
@dschonholtz
Copy link
Contributor Author

This consistently works the first time.
There is something wrong with the agent set up run when this is run multiple times though.
Builds on this PR: #3926

@dschonholtz dschonholtz requested a review from waynehamadi May 18, 2023 15:14
@dschonholtz
Copy link
Contributor Author

This is still a draft.
I probably won't be able to clean this up today.

@github-actions github-actions bot added size/xl and removed size/l labels May 18, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@dschonholtz dschonholtz marked this pull request as ready for review May 18, 2023 15:44
@vercel
Copy link

vercel bot commented May 18, 2023

Deployment failed with the following error:

Resource is limited - try again in 1 hour (more than 100, code: "api-deployments-free-per-day").

@dschonholtz
Copy link
Contributor Author

Will fix conflicts later.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

1 similar comment
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@dschonholtz dschonholtz changed the title create information retrieval challenge a create/fix debug challenge May 19, 2023
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 19, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@vercel vercel bot temporarily deployed to Preview May 19, 2023 15:49 Inactive
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 19, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added size/l and removed size/xl labels May 20, 2023
@waynehamadi
Copy link
Contributor

waynehamadi commented May 29, 2023 •
edited
Loading

@dschonholtz on it, don't worry about conflicts,I will create another PR

@waynehamadi waynehamadi mentioned this pull request May 29, 2023
Closed
6 tasks
@waynehamadi
Copy link
Contributor

#4457

@waynehamadi waynehamadi reopened this May 30, 2023
@waynehamadi @dschonholtz @gravelBridge
create debug challenge
6e1c2e7 
Co-authored-by: Douglas Schonholtz <[email protected]>
Co-authored-by: symphony <[email protected]>
@waynehamadi waynehamadi reopened this May 30, 2023
@waynehamadi waynehamadi force-pushed the feature/debug-chalenge-fix branch from 28fef98 to 6e1c2e7 Compare May 30, 2023 23:06
@waynehamadi waynehamadi changed the title create/fix debug challenge Create Debug Code Challenge May 30, 2023
@waynehamadi waynehamadi changed the title Create Debug Code Challenge Create "Debug Code Challenge" May 30, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 30, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.25 🎉

Comparison is base (87776b2) 69.60% compared to head (6e1c2e7) 69.85%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
+ Coverage   69.60%   69.85%   +0.25%     
==========================================
  Files          72       72              
  Lines        3520     3520              
  Branches      561      561              
==========================================
+ Hits         2450     2459       +9     
+ Misses        883      873      -10     
- Partials      187      188       +1

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi merged commit f6ee61d into Significant-Gravitas:master May 30, 2023
@waynehamadi
Copy link
Contributor

thank you @dschonholtz @gravelBridge !!

This was referenced May 31, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynehamadi waynehamadi waynehamadi approved these changes

Assignees
No one assigned
Labels
behaviour change size/l
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dschonholtz @waynehamadi @Auto-GPT-Bot