Add $ to timestamp in ci.yml and improve diff #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4266 +/- ##
=======================================
Coverage 62.82% 62.82%
=======================================
Files 73 73
Lines 3373 3373
Branches 487 487
=======================================
Hits 2119 2119
Misses 1107 1107
Partials 147 147 ☔ View full report in Codecov by Sentry. |
waynehamadi
changed the title
richbeales
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The new PRs that create cassettes seem to be created but the PR branch uses TIMESTAMP_COMMIT hard coded instead of the actual timestamp.
The $ to the timestamp was missing. This was working properly without it on my fork but on the repo it doesn't.
Changes
Also added tests to the diff
Documentation
Test Plan
Merge and then see if the timestamp
PR Quality Checklist
black .andisort .against my code to ensure it passes our linter.