-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pipeline: create cassettes in fork #4257
CI Pipeline: create cassettes in fork #4257
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4257 +/- ##
=======================================
Coverage 62.75% 62.75%
=======================================
Files 73 73
Lines 3367 3367
Branches 487 487
=======================================
Hits 2113 2113
Misses 1107 1107
Partials 147 147 ☔ View full report in Codecov by Sentry. |
771ddab
to
e8d5085
Compare
e8d5085
to
cdf487c
Compare
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
857faec
to
fb17f13
Compare
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size |
dd48514
to
ec8eebb
Compare
I’m gonna start being a bit more insistent about a couple things. What is the GitHub action you are using? This is about security so we want to make sure we aren’t exposing ourselves to a pr bot someone else owns that will exfiltrate keys or something. You have asked for multiple reviews so don’t leave this as a draft PR. That’s confusing. What’s the test plan. I’m assuming that the plan is to just keep putting in hot fixes until the pipeline works and cassettes run, but that is exactly that. It is an assumption Technical debt grows and feeds on itself it is worth the time on individual PRs |
@dschonholtz alright I will do that, you have some comments about the actual change ? |
@dschonholtz oh it got merged, but here is the test plan: |
Co-authored-by: Nicholas Tindle <[email protected]>
Background
This is a hotfix for our current cassette workflow.
Current process:
New process:
Changes
Documentation
Test Plan
PR Quality Checklist