Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom_search_engine_id as mandatory for official google search #4228

Conversation

k-boikov
Copy link
Contributor

Background

If you miss your custom_search_engine_id in .env you will get HTTP 400

Changes

Added custom_search_engine_id as mandatory.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 3:14am

@k-boikov k-boikov added the enhancement New feature or request label May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1c96a5a) 62.75% compared to head (47c3725) 62.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4228   +/-   ##
=======================================
  Coverage   62.75%   62.75%           
=======================================
  Files          73       73           
  Lines        3367     3367           
  Branches      487      487           
=======================================
  Hits         2113     2113           
  Misses       1107     1107           
  Partials      147      147           
Impacted Files Coverage Δ
autogpt/commands/google_search.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gravelBridge gravelBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gravelBridge gravelBridge added this to the v0.3.2 Release milestone May 16, 2023
@ntindle ntindle self-assigned this May 17, 2023
@vercel vercel bot temporarily deployed to Preview May 17, 2023 03:14 Inactive
@ntindle ntindle merged commit 2cd835e into Significant-Gravitas:master May 17, 2023
@k-boikov k-boikov deleted the improvement/add_custom_search_engine_id branch May 21, 2023 01:33
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/s
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants