Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands with same name overwriting #4226

Conversation

k-boikov
Copy link
Contributor

Background

Having a command with the same name overwrites the first one even if the second one is disabled.

Changes

Do not register a command if the command is disabled. Add warning if something is gonna overwrite a command.

Related to

#3904

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 15, 2023 6:36pm

waynehamadi
waynehamadi previously approved these changes May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.04 🎉

Comparison is base (16b7e7a) 60.72% compared to head (c329043) 60.76%.

❗ Current head c329043 differs from pull request most recent head 2294423. Consider uploading reports for the commit 2294423 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4226      +/-   ##
==========================================
+ Coverage   60.72%   60.76%   +0.04%     
==========================================
  Files          73       73              
  Lines        3320     3329       +9     
  Branches      475      479       +4     
==========================================
+ Hits         2016     2023       +7     
- Misses       1164     1165       +1     
- Partials      140      141       +1     
Impacted Files Coverage Δ
autogpt/commands/command.py 77.92% <77.77%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales richbeales merged commit d06d8a6 into Significant-Gravitas:master May 15, 2023
@k-boikov k-boikov deleted the bug/commands-with-the-same-name branch May 15, 2023 18:41
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
@kinance
Copy link
Contributor

kinance commented May 23, 2023

Resolves #4210

@ntindle ntindle added this to the v0.4.0 Release milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants