-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commands with same name overwriting #4226
Fix commands with same name overwriting #4226
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4226 +/- ##
==========================================
+ Coverage 60.72% 60.76% +0.04%
==========================================
Files 73 73
Lines 3320 3329 +9
Branches 475 479 +4
==========================================
+ Hits 2016 2023 +7
- Misses 1164 1165 +1
- Partials 140 141 +1
☔ View full report in Codecov by Sentry. |
Resolves #4210 |
Background
Having a command with the same name overwrites the first one even if the second one is disabled.
Changes
Do not register a command if the command is disabled. Add warning if something is gonna overwrite a command.
Related to
#3904
PR Quality Checklist