Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor challenges to use cycle count instead of time #4222

Merged
merged 3 commits into from
May 16, 2023
Merged

Refactor challenges to use cycle count instead of time #4222

merged 3 commits into from
May 16, 2023

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented May 15, 2023 •
edited
Loading

Background

Continuous agents need to be stopped after a certain time, but we don't know that time in advance.
Plus there could be some rate limit errors that make the agent take more time.
So instead of using time let's use the number of cycle.
Other code cleanup added.

Changes

use cycle count instead of time
enforce type hinting on challenges
create a test for challenges to be formatted properly (it's a test testing the tests)

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 16, 2023 0:23am

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 15, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi marked this pull request as draft May 15, 2023 14:52
@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from a76687b to 3c991b1 Compare May 15, 2023 14:55
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from 3c991b1 to b74b0ef Compare May 15, 2023 14:57
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from b74b0ef to 0e53cbf Compare May 15, 2023 16:12
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from 0e53cbf to ee61e79 Compare May 15, 2023 16:15
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 15, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from ee61e79 to d728edd Compare May 15, 2023 16:22
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@codecov
Copy link

codecov bot commented May 15, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (3c80e05) 62.09% compared to head (8746255) 62.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4222      +/-   ##
==========================================
+ Coverage   62.09%   62.33%   +0.23%     
==========================================
  Files          73       73              
  Lines        3327     3329       +2     
  Branches      479      480       +1     
==========================================
+ Hits         2066     2075       +9     
+ Misses       1122     1107      -15     
- Partials      139      147       +8
Impacted Files Coverage Δ
autogpt/prompts/prompt.py 51.92% <0.00%> (-2.08%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from d728edd to 091a633 Compare May 15, 2023 17:55
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/refactor-tests branch from 091a633 to 88e4f5b Compare May 15, 2023 18:01
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi marked this pull request as ready for review May 15, 2023 18:04
@waynehamadi waynehamadi requested a review from a team May 15, 2023 18:04
@waynehamadi waynehamadi changed the title Feature/refactor tests Refactor challenges May 15, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi changed the title Refactor challenges Refactor challenges to use cycle count instead of time May 15, 2023
@dschonholtz
Copy link
Contributor

Could you describe exactly what the cycle count is doing?
I like the idea of enforcing mypy.

@dschonholtz
Copy link
Contributor

Generally this seems like a good thing

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@gravelBridge gravelBridge mentioned this pull request May 16, 2023
Merged
5 tasks
@ntindle ntindle merged commit 6c4426d into Significant-Gravitas:master May 16, 2023
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
@waynehamadi @richbeales @ppetermann
Refactor challenges to use cycle count instead of time (Significant-G…
34d933c 
…ravitas#4222)

Co-authored-by: Richard Beales <[email protected]>
@ntindle ntindle added this to the v0.4.0 Release milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschonholtz dschonholtz dschonholtz left review comments

@richbeales richbeales richbeales left review comments

@ntindle ntindle ntindle approved these changes

Assignees
No one assigned
Labels
size/xl
Projects
AutoGPT development kanban
Archived in project
Milestone
v0.4.0 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@waynehamadi @dschonholtz @richbeales @ntindle