fix: allow absolute paths if contained in workspace #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe I'm missing something but I don't see the harm of accessing an absolute path if it's contained in the workspace
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3932 +/- ##
=======================================
Coverage 62.18% 62.18%
=======================================
Files 73 73
Lines 3345 3345
Branches 484 484
=======================================
Hits 2080 2080
Misses 1118 1118
Partials 147 147
☔ View full report in Codecov by Sentry. |
k-boikov
approved these changes
May 16, 2023
|
thanks! |
ppetermann
pushed a commit
to ppetermann/Auto-GPT
that referenced
this pull request
May 22, 2023
…3932) Maybe I'm missing something but I don't see the harm of accessing an absolute path if it's contained in the workspace Co-authored-by: k-boikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Maybe I'm missing something but I don't see the harm of accessing an absolute path if it's contained in the workspace
Changes
Instead of blindly erroring on absolute paths, let's make an exception if they are contained in the workspace
Documentation
Simple one line change with a clear comment is there
Test Plan
Besides not running into this issue that reported here after my changes:
#3705
I've also instructed the AI to write to absolute paths in my workspace, and try to write to an absolute path outside of the workspace, as well as relative paths inside and outside workspaces
Here are the results:
PR Quality Checklist
I haven't added tests yet because I'm not sure if this is behavior we want, if this is wanted behavior then I'll go ahead and write a test for this
Closes #3705