More control over flow ( interrupt command JIT + choose commands to ignore/stop on + stop when looping ) #3914

eyalk11 · 2023-05-06T16:42:23Z

Background

Now it is quite challenging to control the flow. You would need to assume the next N authorised commands are OK, beforehand. If it goes astray, you have nothing to do, but to wait after the batch.
This commit make it possible to interrupt just in time and define commands that are more and less relevant with regard to batch.

Changes

Added config.commands_to_stop and config.commands_to_ignore.

config.commands_to_stop would stop after the command anyway. For example, you might want to stop on task completion, anyway.

config.commands_to_ignore are commands that authorized automatically and don't increase the counter.

Changed spinner class to allow for interruption

<space> in the middle of thinking means soft-interrupt complete execution and ask for user input after execution).
<q> means abort - exit task immediately and ask for user input.

Have two implementation for linux and windows.

Introduced a function async_task_and_spin to wait for either task completion or interrupt.

Stop if already executed a command

To do so, it keeps all previously executed commands in set.

Documentation

In code

Test Plan

I just checked the code on my own, saw that both soft and hard interrupts working.
commands_to_stop and to_ignore seems to be working.
There was an error in test_memory_trimmed_from_context that seem unrelated.

    memory_found = memory.get_relevant("Important Information", 5)
    assert memory_found[0] == expected_permanent_memory

Want to see if it fails on workflow.

PR Quality Checklist

My pull request is atomic and focuses on a single change. (Arguably, you could split this into adding ignore/to stop and adding spinner. But it is part of whole. )
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

I didn't add tests because of lack of time. A bit of help is wanted, if you think testing is required for it.

This is how soft interrupt looks like. It keeps thinking afterwards.

vercel · 2023-05-06T16:42:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)			May 6, 2023 4:48pm

github-actions · 2023-05-06T16:42:43Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-06T16:43:15Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-06T16:48:33Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-13T02:39:28Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Pwuts · 2023-06-14T23:51:32Z

This looks interesting, and like a significant potential UX improvement

lc0rp · 2023-06-23T15:09:25Z

@eyalk11 We're prepping for release v0.4.3. Please resolve conflicts and stand by as we merge.

eyalk11 · 2023-06-27T23:34:15Z

OK, I am working on this. it is a bit hard to merge. (merge_int branch in my fork).

netlify · 2023-06-28T01:18:27Z

❌ Deploy Preview for auto-gpt-docs failed.

Name	Link
🔨 Latest commit	`24ad3dd`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/64ce9132ccb7610008235587

github-actions · 2023-06-28T01:18:31Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

eyalk11 · 2023-06-28T01:20:53Z

(There are still some merging issues, will solve)

codecov · 2023-06-28T01:29:13Z

Codecov Report

Patch coverage: 59.01% and project coverage change: +0.01% 🎉

Comparison is base (3a2d08f) 51.93% compared to head (24ad3dd) 51.94%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3914      +/-   ##
==========================================
+ Coverage   51.93%   51.94%   +0.01%     
==========================================
  Files         117      117              
  Lines        4987     5088     +101     
  Branches      671      694      +23     
==========================================
+ Hits         2590     2643      +53     
- Misses       2199     2235      +36     
- Partials      198      210      +12

Files Changed	Coverage Δ
autogpt/app/spinner.py	`65.62% <55.55%> (-31.75%)`	⬇️
autogpt/app/main.py	`45.97% <61.70%> (+2.53%)`	⬆️
autogpt/config/config.py	`79.88% <100.00%> (+0.34%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eyalk11 · 2023-07-14T18:51:53Z

I added test for command_to_stop/ignore.

eyalk11 · 2023-07-16T20:26:00Z

requirements.txt

@@ -29,6 +29,7 @@ spacy>=3.0.0,<4.0.0
 en-core-web-sm @ https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-3.5.0/en_core_web_sm-3.5.0-py3-none-any.whl
 prompt_toolkit>=3.0.38
 pydantic
+frozendict



keyboard not in req file because isn't supported on mac.

eyalk11 · 2023-07-16T20:26:19Z

autogpt/spinner.py

+            if (
+                pressed_key
+                and pressed_key == key_to_check
+                or (os.name == "nt" and keyboard.is_pressed(keyboard_key))


will work if out of focus

github-actions · 2023-07-20T15:39:12Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

lc0rp · 2023-07-22T06:31:25Z

@eyalk11 The agent was updated recently, probably the reason for the conflicts.

github-actions · 2023-08-05T00:49:52Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-08-19T15:47:13Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions bot added the size/xl label May 6, 2023

eyalk11 changed the title ~~Interrupt commands~~ Interrupt commands (control flow by interrupting commands JIT or choose commands to ignore/stop on) May 6, 2023

eyalk11 force-pushed the interrupt_commands branch from b495d65 to 105ecce Compare May 6, 2023 16:48

eyalk11 mentioned this pull request May 6, 2023

still looping. #3855

Closed

1 task

eyalk11 changed the title ~~Interrupt commands (control flow by interrupting commands JIT or choose commands to ignore/stop on)~~ More control over flow ( interrupt command JIT + choose commands to ignore/stop on + stop when looping ) May 7, 2023

Boostrix mentioned this pull request May 7, 2023

D/alt command class #3909

Closed

5 tasks

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 13, 2023

k-boikov added the enhancement New feature or request label May 14, 2023

Pwuts added this to the v0.4.2 Release milestone Jun 14, 2023

Pwuts modified the milestones: v0.4.3 Release, v0.4.4 Release Jun 23, 2023

eyalk11 force-pushed the interrupt_commands branch from 105ecce to 4827736 Compare June 28, 2023 01:18

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 28, 2023

github-actions bot added size/l and removed size/xl labels Jun 28, 2023

This was referenced Jun 30, 2023

Adds risk avoidance mode and relevant config. #934

Closed

Introducing Looping Heuristics / Detection #3668

Closed

eyalk11 force-pushed the interrupt_commands branch from 4827736 to 7e26c5c Compare June 30, 2023 17:30

eyalk11 force-pushed the interrupt_commands branch 3 times, most recently from 87d0158 to 592514b Compare July 14, 2023 18:47

eyalk11 force-pushed the interrupt_commands branch 2 times, most recently from 1827465 to f8032a8 Compare July 14, 2023 19:16

eyalk11 commented Jul 16, 2023

View reviewed changes

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 20, 2023

lc0rp added this to the v0.4.7 Release milestone Jul 22, 2023

lc0rp modified the milestones: v0.4.7 Release, v0.4.8 Aug 1, 2023

eyalk11 force-pushed the interrupt_commands branch from f8032a8 to e028f9f Compare August 5, 2023 00:49

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Aug 5, 2023

eyalk11 force-pushed the interrupt_commands branch 3 times, most recently from aadef76 to ce6ad6d Compare August 5, 2023 16:49

Adding more control over flow as a single commit. Discarded test

24ad3dd

eyalk11 force-pushed the interrupt_commands branch from ce6ad6d to 24ad3dd Compare August 5, 2023 18:13

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Aug 19, 2023

Pwuts modified the milestones: v0.4.8, Auto-GPT v0.5.0: Hackathon Ready Sep 8, 2023

Pwuts unassigned collijk Nov 21, 2023

Pwuts modified the milestones: Auto-GPT v0.5.0, Auto-GPT v0.6.0 Dec 13, 2023

Swiftyos closed this Jun 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More control over flow ( interrupt command JIT + choose commands to ignore/stop on + stop when looping ) #3914

More control over flow ( interrupt command JIT + choose commands to ignore/stop on + stop when looping ) #3914

eyalk11 commented May 6, 2023 •

edited

Loading

vercel bot commented May 6, 2023 •

edited

Loading

github-actions bot commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 13, 2023

Pwuts commented Jun 14, 2023

lc0rp commented Jun 23, 2023

eyalk11 commented Jun 27, 2023

netlify bot commented Jun 28, 2023 •

edited

Loading

github-actions bot commented Jun 28, 2023

eyalk11 commented Jun 28, 2023

codecov bot commented Jun 28, 2023 •

edited

Loading

eyalk11 commented Jul 14, 2023 •

edited

Loading

eyalk11 Jul 16, 2023

eyalk11 Jul 16, 2023

github-actions bot commented Jul 20, 2023

lc0rp commented Jul 22, 2023

github-actions bot commented Aug 5, 2023

github-actions bot commented Aug 19, 2023

More control over flow ( interrupt command JIT + choose commands to ignore/stop on + stop when looping ) #3914

More control over flow ( interrupt command JIT + choose commands to ignore/stop on + stop when looping ) #3914

Conversation

eyalk11 commented May 6, 2023 • edited Loading

Background

Changes

Documentation

Test Plan

PR Quality Checklist

vercel bot commented May 6, 2023 • edited Loading

github-actions bot commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 13, 2023

Pwuts commented Jun 14, 2023

lc0rp commented Jun 23, 2023

eyalk11 commented Jun 27, 2023

netlify bot commented Jun 28, 2023 • edited Loading

❌ Deploy Preview for auto-gpt-docs failed.

github-actions bot commented Jun 28, 2023

eyalk11 commented Jun 28, 2023

codecov bot commented Jun 28, 2023 • edited Loading

Codecov Report

eyalk11 commented Jul 14, 2023 • edited Loading

eyalk11 Jul 16, 2023

Choose a reason for hiding this comment

eyalk11 Jul 16, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2023

lc0rp commented Jul 22, 2023

github-actions bot commented Aug 5, 2023

github-actions bot commented Aug 19, 2023

eyalk11 commented May 6, 2023 •

edited

Loading

vercel bot commented May 6, 2023 •

edited

Loading

netlify bot commented Jun 28, 2023 •

edited

Loading

codecov bot commented Jun 28, 2023 •

edited

Loading

eyalk11 commented Jul 14, 2023 •

edited

Loading