Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize environment variables for all agent key bindings #3774

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

scottschluer
Copy link
Contributor

@scottschluer scottschluer commented May 4, 2023

Background

Support for using environment variables to store key bindings was incomplete. Hard-coded references to y, n and s keys were still included in console output. Additionally, there was no environment variable declared for the new SELF_FEEDBACK_KEY.

Changes

Added self_feedback_key to config.py and test_plugins.py. Updated agent.py to use configuration values for all references to "yes", "no" and "self-feedback" keys.

Documentation

No documentation updates required.

Test Plan

Tested locally over several runs. Utilized all keys and verified output and behavior matched expectations.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 6, 2023 2:11pm

@github-actions github-actions bot added the size/m label May 4, 2023
@scottschluer scottschluer force-pushed the configuration-keys branch from b08c9c3 to 325d687 Compare May 4, 2023 05:32
@scottschluer scottschluer changed the title Updated agent.py to utilize environment variables for all key binding… Utilize environment variables for all agent key bindings May 4, 2023
@scottschluer scottschluer force-pushed the configuration-keys branch from 325d687 to 3687f4e Compare May 4, 2023 23:34
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@scottschluer scottschluer force-pushed the configuration-keys branch 2 times, most recently from ee17982 to 9e50d03 Compare May 5, 2023 12:47
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

… references. Added a new configuration key for: SELF_FEEDBACK_KEY.
@scottschluer scottschluer force-pushed the configuration-keys branch from 9e50d03 to 9d6d01a Compare May 6, 2023 14:11
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 13, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Boostrix Boostrix added this to the v0.3.3 Release milestone May 16, 2023
@Boostrix Boostrix requested a review from k-boikov May 16, 2023 14:10
@vercel
Copy link

vercel bot commented Jun 7, 2023

Deployment failed with the following error:

Resource is limited - try again in 9 hours (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e088295) 50.05% compared to head (59087e9) 50.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3774   +/-   ##
=======================================
  Coverage   50.05%   50.05%           
=======================================
  Files         116      116           
  Lines        4799     4799           
  Branches      643      643           
=======================================
  Hits         2402     2402           
  Misses       2218     2218           
  Partials      179      179           
Impacted Files Coverage Δ
autogpt/agent/agent.py 59.18% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ntindle ntindle added the ready-for-maintainer Catalyst has decided this PR looks ready for a maintainer to merge label Jun 7, 2023
@vercel
Copy link

vercel bot commented Jun 7, 2023

Deployment failed with the following error:

Resource is limited - try again in 8 hours (more than 100, code: "api-deployments-free-per-day").

@vercel
Copy link

vercel bot commented Jun 7, 2023

Deployment failed with the following error:

Resource is limited - try again in 7 hours (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 14, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@lc0rp lc0rp modified the milestones: v0.4.1 Release, v0.4.2 Release Jun 14, 2023
@lc0rp lc0rp modified the milestones: v0.4.3 Release, v0.4.4 Release Jun 26, 2023
@Pwuts Pwuts self-assigned this Jul 6, 2023
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/s and removed size/m labels Jul 6, 2023
@Pwuts
Copy link
Member

Pwuts commented Jul 6, 2023

Self feedback mode was removed due to breakage, but your other fixes are still good to have :)

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 59087e9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64a72499ba06c90008543147
😎 Deploy Preview https://deploy-preview-3774--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pwuts Pwuts force-pushed the configuration-keys branch from 0976e9b to 59087e9 Compare July 6, 2023 20:31
@Pwuts Pwuts merged commit 70e8b07 into Significant-Gravitas:master Jul 6, 2023
@scottschluer scottschluer deleted the configuration-keys branch July 9, 2023 16:25
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-maintainer Catalyst has decided this PR looks ready for a maintainer to merge size/s
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants