Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify .env.template image-provider options #3720

Conversation

cwenner
Copy link
Contributor

@cwenner cwenner commented May 3, 2023

Background

I tried using the stable-diffusion image provider based on the .env.template. It did not work with just the option specified under this subsection and settings had to be lifted from another provider. The literal for the SD image provider had to be found in the source code. This seemed straightforward to make more accessible.

Changes

  • Move out the explanation for the two shared image-provider settings in .env.template so that they are not explained under a single provider's section.
  • Add uncommentable lines with the specific IMAGE_PROVIDER values for each of provider options in .env.template, along with a standard IMAGE_SIZE.

Documentation

Improves documentation lines in .env.template. No other documentation required.

Test Plan

  • With SD running, uncommented these options for SD webui in .env; ran the agent and it successfully used generate_image.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

No tests added as it improves the env template's commented-out lines, which did not have tests previously and are likely not intended to be tested.

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 16, 2023 8:55am

@github-actions github-actions bot added the size/m label May 3, 2023
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@Boostrix
Copy link
Contributor

Boostrix commented May 5, 2023

this seem to be stricly config only, and only adding/documenting options/comments - so should be pretty safe to consider as a candidate for pre-arch review.

@Boostrix Boostrix mentioned this pull request May 5, 2023
4 tasks
@k-boikov k-boikov added the documentation Improvements or additions to documentation label May 14, 2023
@k-boikov k-boikov added this to the v0.3.2-release milestone May 14, 2023
@k-boikov k-boikov self-assigned this May 15, 2023
@vercel
Copy link

vercel bot commented May 16, 2023

Deployment failed with the following error:

Resource is limited - try again in 2 hours (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added size/s and removed size/m labels May 16, 2023
ntindle
ntindle previously approved these changes May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.09 ⚠️

Comparison is base (85fe6f3) 62.26% compared to head (07152a4) 62.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3720      +/-   ##
==========================================
- Coverage   62.26%   62.18%   -0.09%     
==========================================
  Files          73       73              
  Lines        3339     3345       +6     
  Branches      482      484       +2     
==========================================
+ Hits         2079     2080       +1     
- Misses       1113     1118       +5     
  Partials      147      147              
Impacted Files Coverage Δ
autogpt/main.py 0.00% <0.00%> (ø)
autogpt/utils.py 63.15% <33.33%> (-0.98%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov merged commit 0839a16 into Significant-Gravitas:master May 16, 2023
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
* Clarify .env.template image-provider options

* feat: consolidate duplicate options

* Simplify

---------

Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: Nicholas Tindle <[email protected]>
Co-authored-by: k-boikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/s
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants