Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in safe_google_results, added tests #3606

Conversation

k-boikov
Copy link
Contributor

@k-boikov k-boikov commented May 1, 2023

Background

Improve code coverage.

Changes

Added missing .decode("utf-8") to safe_google_results, added tests

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2023 6:52pm

@github-actions github-actions bot added the size/l label May 1, 2023
@k-boikov k-boikov force-pushed the improvement/google-search-tests branch from d705260 to f7ac3ca Compare May 1, 2023 03:48
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.20 🎉

Comparison is base (d06d8a6) 60.74% compared to head (221cbc1) 61.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
+ Coverage   60.74%   61.94%   +1.20%     
==========================================
  Files          73       73              
  Lines        3327     3327              
  Branches      479      479              
==========================================
+ Hits         2021     2061      +40     
+ Misses       1165     1125      -40     
  Partials      141      141              
Impacted Files Coverage Δ
autogpt/commands/google_search.py 100.00% <ø> (+100.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov marked this pull request as ready for review May 1, 2023 03:49
@ntindle ntindle self-assigned this May 1, 2023
@k-boikov k-boikov marked this pull request as draft May 1, 2023 11:03
@ntindle ntindle added the testing label May 2, 2023
@vercel vercel bot temporarily deployed to Preview May 2, 2023 19:13 Inactive
@k-boikov k-boikov marked this pull request as ready for review May 2, 2023 19:15
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@vercel vercel bot temporarily deployed to Preview May 15, 2023 18:04 Inactive
@richbeales richbeales merged commit cf35112 into Significant-Gravitas:master May 15, 2023
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
@ntindle ntindle added this to the v0.4.0 Release milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants