Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split_file when overlap = 0, add test #3599

Merged

Conversation

k-boikov
Copy link
Contributor

Background

split_file would eat 1 symbol when overlap = 0 because of end + (-1)
image

Changes

use max(offset, 0) to ensure we never subtract from "end"

Test Plan

Added test for overlap = 0

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2023 0:50am

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (57ea7b5) 63.79% compared to head (4e8c710) 63.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3599      +/-   ##
==========================================
+ Coverage   63.79%   63.82%   +0.02%     
==========================================
  Files          74       74              
  Lines        3447     3447              
  Branches      507      507              
==========================================
+ Hits         2199     2200       +1     
  Misses       1079     1079              
+ Partials      169      168       -1     
Impacted Files Coverage Δ
autogpt/commands/file_operations.py 83.72% <100.00%> (+0.58%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov marked this pull request as ready for review May 1, 2023 00:37
@k-boikov k-boikov force-pushed the improvement/fix-file-split branch from b848000 to 1d12e87 Compare May 1, 2023 01:24
@github-actions github-actions bot added size/m conflicts Automatically applied to PRs with merge conflicts and removed size/s labels May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@vercel vercel bot temporarily deployed to Preview May 2, 2023 11:33 Inactive
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@vercel vercel bot temporarily deployed to Preview May 14, 2023 09:56 Inactive
@vercel
Copy link

vercel bot commented May 14, 2023

Deployment failed with the following error:

Resource is limited - try again in 45 minutes (more than 100, code: "api-deployments-free-per-day").

@k-boikov k-boikov added this to the v0.3.2 Release milestone May 17, 2023
@vercel vercel bot temporarily deployed to Preview May 17, 2023 23:29 Inactive
@bfalans bfalans self-assigned this May 20, 2023
@vercel vercel bot temporarily deployed to Preview May 20, 2023 23:07 Inactive
@ntindle ntindle merged commit bcc32cc into Significant-Gravitas:master May 21, 2023
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants