-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix split_file when overlap = 0, add test #3599
Fix split_file when overlap = 0, add test #3599
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3599 +/- ##
==========================================
+ Coverage 63.79% 63.82% +0.02%
==========================================
Files 74 74
Lines 3447 3447
Branches 507 507
==========================================
+ Hits 2199 2200 +1
Misses 1079 1079
+ Partials 169 168 -1
☔ View full report in Codecov by Sentry. |
b848000
to
1d12e87
Compare
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
Deployment failed with the following error:
|
Co-authored-by: Nicholas Tindle <[email protected]>
Background
split_file would eat 1 symbol when overlap = 0 because of end + (-1)
Changes
use max(offset, 0) to ensure we never subtract from "end"
Test Plan
Added test for overlap = 0
PR Quality Checklist