Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check for Python 3.10 and print error message if required version not detected. #3598

Merged
merged 9 commits into from
May 16, 2023

Conversation

amokduke
Copy link
Contributor

@amokduke amokduke commented Apr 30, 2023

Background

This pull request adds a check for Python 3.10 and above before running the Auto GPT script. This change ensures that the script only runs in supported Python versions, improving stability and reliability.

Changes

The code has been modified to check for Python 3.10 and above before running the Auto GPT script. If the required version of Python is not detected, an error message is printed to the console.

Documentation

The changes have been documented with in-code comments to explain the purpose and functionality of the added code.

Test Plan

The changes have been tested on a local machine running Python 3.10 and above. The script was also tested with lower versions of Python to ensure that the error message is displayed when attempting to run Auto GPT.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • [] I have added new test cases to cover the added functionality. <= Not Applicable

…formative error messages for unsupported versions.
@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2023 3:05pm

@vercel vercel bot temporarily deployed to Preview April 30, 2023 21:58 Inactive
@amokduke amokduke mentioned this pull request Apr 30, 2023
5 tasks
@Boostrix
Copy link
Contributor

Boostrix commented May 2, 2023

Note that this is more important than people may think, since python 3.10 is now really being required - until yesterday the stable branch would still work with 3.8 (which still is the default on some distros), but today's changes require at least 3.10+

@amokduke amokduke changed the title Python version check Adds check for Python 3.10 and print error message if required version not detected. May 3, 2023
@amokduke amokduke force-pushed the python-versionCheck branch from b777ee3 to a4ff4ff Compare May 3, 2023 08:47
@vercel vercel bot temporarily deployed to Preview May 3, 2023 08:47 Inactive
@github-actions github-actions bot added the size/m label May 3, 2023
@vercel vercel bot temporarily deployed to Preview May 3, 2023 08:53 Inactive
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 14, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 15, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f424fac) 62.75% compared to head (82347b9) 62.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   62.75%   62.75%           
=======================================
  Files          73       73           
  Lines        3367     3367           
  Branches      487      487           
=======================================
  Hits         2113     2113           
  Misses       1107     1107           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amokduke amokduke changed the base branch from stable to master May 15, 2023 12:29
@Boostrix Boostrix added this to the v0.3.2 Release milestone May 16, 2023
@waynehamadi waynehamadi merged commit 627aeb2 into Significant-Gravitas:master May 16, 2023
ppetermann pushed a commit to ppetermann/Auto-GPT that referenced this pull request May 22, 2023
…n not detected. (Significant-Gravitas#3598)

* Updated run script to check for Python 3.10 and above, and provide informative error messages for unsupported versions.

* Updated run script to check for Python 3.10 and above, and provide informative error messages for unsupported versions.

---------

Co-authored-by: merwanehamadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants