Add CLI args for `ai_name`, `ai_role`, and `ai_goals` #3250

rocks6 · 2023-04-25T20:51:07Z

Background

#3079 - currently you have to either specify the ai_settings.yaml file or provide user input in order to set the ai name, roles, and goals. Ideally we can set these via command line and directly enter execution.

Changes

Added command line params for the above, and then passed them down to the configurator in a way that allows you to specify ANY of them (while prompting for the rest if necessary). Command line overrides will override any ai settings files if both are provided, by design.

Documentation

Updated comments and documented tests - TODO update main docs

Test Plan

Created new unit tests and manually ran a couple prompts

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

github-actions · 2023-04-25T20:51:15Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

vercel · 2023-04-26T21:02:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		Apr 29, 2023 8:26pm

github-actions · 2023-04-26T21:03:10Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-04-26T21:03:11Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-26T21:04:02Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-26T21:07:39Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

codecov · 2023-04-26T21:08:45Z

Codecov Report

Patch coverage: 61.62% and project coverage change: -0.02 ⚠️

Comparison is base (e4a337f) 50.05% compared to head (a3f3250) 50.04%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
- Coverage   50.05%   50.04%   -0.02%     
==========================================
  Files         116      116              
  Lines        4799     4826      +27     
  Branches      643      650       +7     
==========================================
+ Hits         2402     2415      +13     
- Misses       2218     2227       +9     
- Partials      179      184       +5

Impacted Files	Coverage Δ
autogpt/cli.py	`0.00% <0.00%> (ø)`
autogpt/config/ai_config.py	`77.04% <ø> (-0.73%)`	⬇️
autogpt/llm/chat.py	`66.23% <0.00%> (-2.60%)`	⬇️
autogpt/memory/vector/utils.py	`78.12% <0.00%> (-5.21%)`	⬇️
autogpt/prompts/prompt.py	`41.50% <18.18%> (-4.15%)`	⬇️
autogpt/llm/utils/__init__.py	`49.25% <20.00%> (-1.48%)`	⬇️
autogpt/main.py	`23.68% <33.33%> (+1.60%)`	⬆️
autogpt/agent/agent.py	`59.18% <50.00%> (ø)`
autogpt/setup.py	`73.07% <73.33%> (-6.64%)`	⬇️
autogpt/config/config.py	`83.89% <93.33%> (+4.75%)`	⬆️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rocks6 · 2023-04-27T04:26:21Z

merge messed this up, I need to fix it

github-actions · 2023-04-27T20:27:42Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-28T16:48:29Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions · 2023-04-29T12:24:17Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-29T12:25:19Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-29T12:33:35Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-04-29T12:33:44Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-04-29T12:35:43Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-06-19T02:20:32Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

…-GPT into pr/3250

github-actions · 2023-06-21T14:11:09Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-06-24T09:27:27Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions · 2023-07-07T00:21:03Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

Pwuts

LGTM!

…avitas#3250) * add capability to specify AI config at cmd line * Make `--ai-goal` multi-parameter * Fix argument forwarding in run.sh --------- Co-authored-by: Reinier van der Leer <[email protected]>

rocks6 added 3 commits April 24, 2023 20:07

add capability to specify AI config at cmd line

386e8a4

add tests

524ece1

add more tests

55a40c5

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 25, 2023

github-actions bot added the size/l label Apr 25, 2023

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 26, 2023

github-actions bot added size/xl and removed size/l labels Apr 26, 2023

vercel bot temporarily deployed to Preview April 26, 2023 21:04 Inactive

vercel bot temporarily deployed to Preview April 26, 2023 21:08 Inactive

vercel bot temporarily deployed to Preview April 27, 2023 20:28 Inactive

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2023

vercel bot temporarily deployed to Preview April 29, 2023 12:24 Inactive

vercel bot temporarily deployed to Preview April 29, 2023 12:25 Inactive

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 29, 2023

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 19, 2023

Merge branch 'master' of https://github.com/Significant-Gravitas/Auto…

65a4a61

…-GPT into pr/3250

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 21, 2023

Pwuts removed their assignment Jun 21, 2023

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 24, 2023

lc0rp modified the milestones: v0.4.3 Release, v0.4.4 Release Jun 26, 2023

Merge branch 'master' into add-cmd-line-args

d50b8e3

lc0rp modified the milestones: v0.4.4 Release, v0.4.5 Release Jul 6, 2023

Simplify

735fb70

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 7, 2023

Pwuts added 4 commits July 7, 2023 02:22

Merge branch 'master' into add-cmd-line-args

1f2765e

Merge branch 'master' into add-cmd-line-args

3e48be3

Merge branch 'master' into add-cmd-line-args

141b471

Fix linting

f7341ca

Pwuts force-pushed the add-cmd-line-args branch from 98425e0 to fe4e161 Compare July 7, 2023 02:01

Remove tests because fixing them is complicated

a3f3250

Pwuts force-pushed the add-cmd-line-args branch from fe4e161 to a3f3250 Compare July 7, 2023 02:01

Pwuts added the needs manual testing label Jul 7, 2023

Fix argument forwarding in run.sh

d45f561

Pwuts modified the milestones: v0.4.5 Release, v0.4.4 Release Jul 7, 2023

Pwuts approved these changes Jul 7, 2023

View reviewed changes

Pwuts merged commit 9e5492b into Significant-Gravitas:master Jul 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CLI args for `ai_name`, `ai_role`, and `ai_goals` #3250

Add CLI args for `ai_name`, `ai_role`, and `ai_goals` #3250

rocks6 commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

vercel bot commented Apr 26, 2023 •

edited

Loading

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

codecov bot commented Apr 26, 2023 •

edited

Loading

rocks6 commented Apr 27, 2023

github-actions bot commented Apr 27, 2023

github-actions bot commented Apr 28, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Jun 19, 2023

github-actions bot commented Jun 21, 2023

github-actions bot commented Jun 24, 2023

github-actions bot commented Jul 7, 2023

Pwuts left a comment

Add CLI args for ai_name, ai_role, and ai_goals #3250

Add CLI args for ai_name, ai_role, and ai_goals #3250

Conversation

rocks6 commented Apr 25, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

github-actions bot commented Apr 25, 2023

vercel bot commented Apr 26, 2023 • edited Loading

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

github-actions bot commented Apr 26, 2023

codecov bot commented Apr 26, 2023 • edited Loading

Codecov Report

rocks6 commented Apr 27, 2023

github-actions bot commented Apr 27, 2023

github-actions bot commented Apr 28, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Apr 29, 2023

github-actions bot commented Jun 19, 2023

github-actions bot commented Jun 21, 2023

github-actions bot commented Jun 24, 2023

github-actions bot commented Jul 7, 2023

Pwuts left a comment

Choose a reason for hiding this comment

Add CLI args for `ai_name`, `ai_role`, and `ai_goals` #3250

Add CLI args for `ai_name`, `ai_role`, and `ai_goals` #3250

vercel bot commented Apr 26, 2023 •

edited

Loading

codecov bot commented Apr 26, 2023 •

edited

Loading