Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test test_generate_aiconfig_automatic_typical as @requires_api_… #2981

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

richbeales
Copy link
Contributor

…key("OPENAI_API_KEY")

Background

A test that required an api key to run was not marked as such

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

ntindle
ntindle previously approved these changes Apr 23, 2023
@ntindle
Copy link
Member

ntindle commented Apr 23, 2023

Needs import of @needs_api_key from tests.utils

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f462674) 46.14% compared to head (913fda6) 46.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2981   +/-   ##
=======================================
  Coverage   46.14%   46.14%           
=======================================
  Files          60       60           
  Lines        2889     2889           
  Branches      475      475           
=======================================
  Hits         1333     1333           
  Misses       1447     1447           
  Partials      109      109           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales richbeales merged commit bb78646 into master Apr 23, 2023
@richbeales richbeales deleted the richbeales-patch-2 branch April 23, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants