Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix coverage tooling #2771

Merged
merged 9 commits into from
Apr 21, 2023
Merged

[Hotfix] Fix coverage tooling #2771

merged 9 commits into from
Apr 21, 2023

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Apr 21, 2023

Background

Minor issue with CI failing due to push events trying to upload coverage

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@ntindle ntindle changed the title [Hotfix] Don [Hotfix] Don't upload coverage results on push Apr 21, 2023
hdkiller
hdkiller previously approved these changes Apr 21, 2023
@github-actions github-actions bot added size/m and removed size/xs labels Apr 21, 2023
@github-actions github-actions bot added size/l and removed size/m labels Apr 21, 2023
@ntindle ntindle changed the title [Hotfix] Don't upload coverage results on push [Hotfix] Fix coverage tooling Apr 21, 2023
@ntindle ntindle requested a review from hdkiller April 21, 2023 06:04
@ntindle
Copy link
Member Author

ntindle commented Apr 21, 2023

I hate that this is size/l

@k-boikov k-boikov added the ci label Apr 21, 2023
@Pwuts
Copy link
Member

Pwuts commented Apr 21, 2023

As mentioned in the original issue, we could just install Codecov. Easier to configure and doesn't require the same extensive permissions.

@ntindle
Copy link
Member Author

ntindle commented Apr 21, 2023

Someone with full repo control would need to set that up and I’m not sure if it’s free

@richbeales
Copy link
Contributor

CodeCov appears to be free for OSS projects. We do need to fix the CI @Pwuts are you happy for this to be merged and we can check out codecov at a later date?

@ntindle
Copy link
Member Author

ntindle commented Apr 21, 2023

If I get perms to add code cov, I’d love to. Otherwise I’d just like to get this working

@richbeales richbeales merged commit a2e1669 into Significant-Gravitas:master Apr 21, 2023
@richbeales
Copy link
Contributor

merged, better to fix CI now rather than wait for an unknown amount of time for a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants