-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huggingface retry generate_image with delay #2745
Huggingface retry generate_image with delay #2745
Conversation
Do me a solid and update this so we can merge |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2745 +/- ##
==========================================
- Coverage 49.70% 42.38% -7.32%
==========================================
Files 64 64
Lines 3026 3048 +22
Branches 507 510 +3
==========================================
- Hits 1504 1292 -212
- Misses 1402 1689 +287
+ Partials 120 67 -53
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Code coverage added for all cases here.
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Fixed the tests partially by removing them 😅 If you can add a test that's appropriate |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Deployment failed with the following error:
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Deployment failed with the following error:
|
Deployment failed with the following error:
|
Co-authored-by: Media <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: k-boikov <[email protected]> Co-authored-by: merwanehamadi <[email protected]> Co-authored-by; lc0rp
Background
The command
generate_image
with huggingface may return an error response due to the service queuing the request. This results in the image failing to generate. A delay may be invoked and the request retried, in order to return a successful image.Changes
Documentation
Test Plan
PR Quality Checklist