Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❇️ Improved OpenAI API Key Insert to Env #2486

Merged
merged 10 commits into from
Jun 24, 2023

Conversation

Qoyyuum
Copy link
Contributor

@Qoyyuum Qoyyuum commented Apr 19, 2023

Background

Relates to #2148 but most commonly to fix a lot of users trying to use the AutoGPT and failed to set up their .env file or to set up the environment variable properly.

Changes

Improved check_openai_api_key() function

Documentation

Documented in the function itself. It's a small singular atomic function that handles checking and having the user input into the environment variable and Config of AutoGPT.

Test Plan

Manually run the function. Unable to write a unit test script that can handle user input.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@Qoyyuum Qoyyuum requested a review from BillSchumacher April 19, 2023 06:43
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 20, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 20, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

Pwuts

This comment was marked as resolved.

@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@vercel
Copy link

vercel bot commented May 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2023 5:48am

@vercel vercel bot temporarily deployed to Preview May 20, 2023 12:42 Inactive
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: -0.20 ⚠️

Comparison is base (222101b) 70.87% compared to head (566ae7e) 70.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2486      +/-   ##
==========================================
- Coverage   70.87%   70.68%   -0.20%     
==========================================
  Files          68       68              
  Lines        3317     3326       +9     
  Branches      531      532       +1     
==========================================
  Hits         2351     2351              
- Misses        788      798      +10     
+ Partials      178      177       -1     
Impacted Files Coverage Δ
autogpt/config/config.py 68.63% <10.00%> (-3.24%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov added this to the v0.3.3 Release milestone May 21, 2023
@lc0rp
Copy link
Contributor

lc0rp commented Jun 7, 2023

Are we ok with putting this in place temporarily? It's probably worth waiting for #4604 to be implemented so that we don't change things for users too often.

I'll flag it for discussion.

@lc0rp lc0rp added needs discussion To be discussed among maintainers ready-for-maintainer Catalyst has decided this PR looks ready for a maintainer to merge size/s and removed size/m labels Jun 7, 2023
@github-actions github-actions bot added size/m and removed size/s labels Jun 7, 2023
@vercel vercel bot temporarily deployed to Preview June 7, 2023 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview June 11, 2023 05:48 Inactive
@Pwuts
Copy link
Member

Pwuts commented Jun 11, 2023

Are we ok with putting this in place temporarily? It's probably worth waiting for #4604 to be implemented [...]

@lc0rp, that depends on the timeline for #4604 :)

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 566ae7e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6496b2420f71c50008524289

@lc0rp lc0rp modified the milestones: v0.4.1 Release, v0.4.2 Release Jun 14, 2023
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@lc0rp lc0rp merged commit 307f6e5 into Significant-Gravitas:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviour change needs discussion To be discussed among maintainers ready-for-maintainer Catalyst has decided this PR looks ready for a maintainer to merge size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants