Prep for #2291 Allow feedback and interrupting during continuous run #2481

ehei · 2023-04-19T02:59:18Z

Background

While running with the 'y -XXX' prompt, I found myself wanting to know how many steps had been performed, and how many were left out of how many I had authorized. Additionally, I wanted a way to interrupt the process without resorting to crashing the system or killing a process outright.

Changes

Changes are extracting some methods for the functionality I eventually want to change and create unit tests for same.

Documentation

Test Plan

Created unit tests for the changes to ensure current functionality and lay the foundation for future changes.

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes.

Ran the app and tested the following inputs:

'n' - exited appropriately
'y -X' - showed error message and re-prompted
'y -2' - continued twice
'(some relevant feedback)' - parsed feedback
'y asdfasdfads' - gave error message and looped back correctly

github-actions · 2023-04-19T02:59:33Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Pwuts · 2023-04-22T10:40:30Z

~~Sidenote, point of feedback: for us it would have been much more convenient (project management-wise) if you had updated #2291 instead of opening a new PR for the same thing.~~ Nevermind, misunderstood the purpose of the PR

Pwuts · 2023-04-22T10:51:36Z

Can you please resolve the conflicts so we can review? :)

ehei · 2023-04-22T15:33:35Z

Terribly sorry. I'll fix that this weekend.

…

On Sat, Apr 22, 2023, 6:51 AM Reinier van der Leer ***@***.***> wrote: Can you please resolve the conflicts so we can review? :) — Reply to this email directly, view it on GitHub <#2481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVTCVBAR7DHMIYSRUCUJ6DXCOZ4JANCNFSM6AAAAAAXDN7S2Y> . You are receiving this because you authored the thread.Message ID: ***@***.***>

github-actions · 2023-04-22T16:23:51Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-04-23T23:38:23Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions · 2023-04-24T01:02:39Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

codecov · 2023-04-24T13:14:24Z

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.87 🎉

Comparison is base (4a20616) 41.66% compared to head (3f1e498) 42.53%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2481      +/-   ##
==========================================
+ Coverage   41.66%   42.53%   +0.87%     
==========================================
  Files          65       65              
  Lines        3029     3042      +13     
  Branches      507      509       +2     
==========================================
+ Hits         1262     1294      +32     
+ Misses       1702     1682      -20     
- Partials       65       66       +1

Impacted Files	Coverage Δ
autogpt/agent/agent.py	`36.80% <65.62%> (+23.52%)`	⬆️
autogpt/api_manager.py	`88.88% <100.00%> (+0.20%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-05-08T15:57:00Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions · 2023-05-08T15:57:04Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-08T16:03:53Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-actions · 2023-05-08T16:03:57Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

resolved

k-boikov · 2023-05-09T19:10:12Z

autogpt/agent/agent.py

+        command_registry: CommandRegistry,
+        config: AIConfig,
+        system_prompt: str,
+        initial_prompt: str,


That is still triggering_prompt I am afraid, it is the message we send at the end of a "conversation" in order to trigger a response. Please explain the change.

This was my change; I found triggering_prompt to be a bit ambiguous and thought renaming it could help, although I see my choice of name could have been better.

k-boikov · 2023-05-09T19:37:49Z

autogpt/agent/agent.py

+                if self.autonomous_cycles_remaining > 0:
+                    self.autonomous_cycles_remaining -= 1
+
+                # Check if there's a result from the command append it to the message


There is something really wrong here, that code should be outside of the else scope, why was it tabbed?

k-boikov · 2023-05-09T19:59:17Z

Overall not a big fan of the determine_next_command addition, we do elseif there and then we do elseif again outside to check the determine_next_command's result.

ehei · 2023-05-11T12:04:17Z

It started out much simpler, but with a bunch of other PRs getting pushed on top, and a bunch of refactoring I'm working on merging in from another reviewer, things get way more complicated. Still working on the PR (week 5 and counting).

…

On Tue, May 9, 2023 at 3:59 PM k-boikov ***@***.***> wrote: Overall not a big fan of the determine_next_command addition, we do elseif there and then we do elseif again outside to check the determine_next_command's result. — Reply to this email directly, view it on GitHub <#2481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVTCVBKGOPKE2ZZHMVL42TXFKO2DANCNFSM6AAAAAAXDN7S2Y> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Boostrix · 2023-05-11T12:10:47Z

To be fair, some of this was suggested by other folks, too - and some of it may even be covered by similar PRs. So maybe this needs a little more planning/coordination. Personally, I can definitely see the need for this!

Even moreso because the current design has zero support for persistence, let alone for recovering a workspace properly.
Thus, being able to pause an agent to "direct" it would seem like a good compromise.

Usually, there's a ton of work (API tokens + time) going to the wastebin once we realize that the agent went off an irrelevant trajectory.

So given the state of affairs, the feature itself could be useful regardless of stylistic disagreements at the code level

ehei · 2023-05-11T13:04:19Z

I'm going to work to get everything running today, so there should be a (somewhat) cleaner PR here later today. Appreciate all the help and comments.

…

On Thu, May 11, 2023 at 8:10 AM Boostrix ***@***.***> wrote: To be fair, some of this was suggested by other folks, too - and some of it may even be covered by similar PRs. So maybe this needs a little more planning/coordination. Personally, I can definitely see the need for this! Even moreso because the current design has zero support for persistence, let alone for recovering a workspace properly. Thus, being able to pause an agent to "direct" it would seem like a good compromise. Usually, there's a ton of work (API tokens + time) going to the wastebin once we realize that the agent went off an irrelevant trajectory. So given the state of affairs, the feature itself could be useful regardless of stylistic disagreements at the code level — Reply to this email directly, view it on GitHub <#2481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVTCVCTAQMRDNIZL2M2DC3XFTJNHANCNFSM6AAAAAAXDN7S2Y> . You are receiving this because you were mentioned.Message ID: ***@***.***>

github-actions · 2023-05-11T13:54:54Z

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

github-actions · 2023-05-13T01:08:36Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

ehei · 2023-05-13T15:37:30Z

Happy to jump on Discord and figure out how best to accomplish this. Just let me know (ericheikkila#1667)

Boostrix · 2023-05-15T22:12:24Z

Hi, just a short update - thanks for taking the time to update your PR, your PR was today discussed on Discord by several devs and it's being assigned to be reviewed right now!

So, given that there seem to be at least 5+ different PRs in the pipeline currently using similar but still a different method, it is likely that we're going to take parts from each and every one of these PRs, to ensure that the feature is well-aligned with the ongoing re-arch effort.

This means, you will end up in the credits automagically - but won't have to do any more work from now on.

If there are remaining questions, someone is going to contact you, the PR is being reviewed by @gravelBridge

ehei · 2023-05-15T22:19:21Z

Understood. Looking forward to the smoke settling so I can get back to it. :) Thanks for the update.

…

On Mon, May 15, 2023, 6:12 PM Boostrix ***@***.***> wrote: Hi, just a short update - thanks for taking the time to update your PR, your PR was today discussed on Discord by several devs and it's being assigned to be reviewed right now! So, given that there seem to be at least 5+ different PRs in the pipeline currently using similar but still a different method, it is likely that we're going to take parts from each and every one of these PRs, to ensure that the feature is well-aligned with the ongoing re-arch effort. This means, you will end up in the credits automagically - but won't have to do any more work from now on. If there are remaining questions, someone is going to contact you, the PR is being reviewed by @gravelBridge <https://github.com/gravelBridge> — Reply to this email directly, view it on GitHub <#2481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVTCVCFVJHLNHGXOA4LZPTXGKS5HANCNFSM6AAAAAAXDN7S2Y> . You are receiving this because you were mentioned.Message ID: ***@***.***>

gravelBridge · 2023-05-16T04:53:53Z

Hello! Thank you so much for your contribution and feature suggestion! I have finished implementing our version of this feature here: #4230. Once again, thank you!

ehei · 2023-05-23T15:12:30Z

AWESOME!! Thanks again!

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 19, 2023

Pwuts added the enhancement New feature or request label Apr 22, 2023

This was linked to issues Apr 22, 2023

Show how many auto command remaining when using y -N #1035

Closed

A way to stop executing of "y -100" without killing the program #1472

Closed

This was unlinked from issues Apr 22, 2023

Show how many auto command remaining when using y -N #1035

Closed

A way to stop executing of "y -100" without killing the program #1472

Closed

Pwuts mentioned this pull request Apr 22, 2023

Allow interrupting continuous iteration #2291

Closed

5 tasks

Pwuts requested review from Torantulino and a team April 22, 2023 10:50

Pwuts changed the title ~~Allow feedback and interrupting during continuous run~~ Prep for #2291 Allow feedback and interrupting during continuous run Apr 22, 2023

Pwuts self-assigned this Apr 22, 2023

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 22, 2023

github-actions bot added the size/xl label Apr 22, 2023

ehei force-pushed the stable branch from aa169bb to 91537b0 Compare April 23, 2023 23:38

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 23, 2023

refix merge conflicts

047ac4f

ehei force-pushed the stable branch from 91537b0 to 047ac4f Compare April 24, 2023 01:00

github-actions bot added size/l and removed size/xl labels Apr 24, 2023

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 24, 2023

ehei added 2 commits April 24, 2023 02:02

Merge branch 'master' into stable

8538e8b

Merge branch 'master' into stable

4025583

Merge remote-tracking branch 'origin/master' into pr-2481

42cfc71

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 8, 2023

vercel bot temporarily deployed to Preview May 8, 2023 16:04 Inactive

Boostrix mentioned this pull request May 9, 2023

Implement Logging of Self-Feedback in logs/Debug Folder #3868

Merged

5 tasks

k-boikov suggested changes May 9, 2023

View reviewed changes

merge attempt 3

30e87da

getting closer with refactorings

cdf4a27

finish making agent tests pass

e087ad0

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 13, 2023

p-i- modified the milestones: v0.3.1 Release, v0.3.2-release May 14, 2023

Boostrix mentioned this pull request May 15, 2023

Automated Self Feedback #4220

Closed

1 task

gravelBridge mentioned this pull request May 16, 2023

Added feature to interrupt y -N continuous commands. #4230

Merged

5 tasks

gravelBridge closed this May 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prep for #2291 Allow feedback and interrupting during continuous run #2481

Prep for #2291 Allow feedback and interrupting during continuous run #2481

ehei commented Apr 19, 2023 •

edited

Loading

github-actions bot commented Apr 19, 2023

Pwuts commented Apr 22, 2023 •

edited

Loading

Pwuts commented Apr 22, 2023

ehei commented Apr 22, 2023 via email

github-actions bot commented Apr 22, 2023

github-actions bot commented Apr 23, 2023

github-actions bot commented Apr 24, 2023

codecov bot commented Apr 24, 2023 •

edited

Loading

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

k-boikov May 9, 2023

Pwuts May 13, 2023

k-boikov May 9, 2023

k-boikov commented May 9, 2023

ehei commented May 11, 2023 via email

Boostrix commented May 11, 2023

ehei commented May 11, 2023 via email

github-actions bot commented May 11, 2023

github-actions bot commented May 13, 2023

ehei commented May 13, 2023

Boostrix commented May 15, 2023

ehei commented May 15, 2023 via email

gravelBridge commented May 16, 2023

ehei commented May 23, 2023

Prep for #2291 Allow feedback and interrupting during continuous run #2481

Prep for #2291 Allow feedback and interrupting during continuous run #2481

Conversation

ehei commented Apr 19, 2023 • edited Loading

Background

Changes

Documentation

Test Plan

PR Quality Checklist

github-actions bot commented Apr 19, 2023

Pwuts commented Apr 22, 2023 • edited Loading

Pwuts commented Apr 22, 2023

ehei commented Apr 22, 2023 via email

github-actions bot commented Apr 22, 2023

github-actions bot commented Apr 23, 2023

github-actions bot commented Apr 24, 2023

codecov bot commented Apr 24, 2023 • edited Loading

Codecov Report

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

github-actions bot commented May 8, 2023

k-boikov May 9, 2023

Choose a reason for hiding this comment

Pwuts May 13, 2023

Choose a reason for hiding this comment

k-boikov May 9, 2023

Choose a reason for hiding this comment

k-boikov commented May 9, 2023

ehei commented May 11, 2023 via email

Boostrix commented May 11, 2023

ehei commented May 11, 2023 via email

github-actions bot commented May 11, 2023

github-actions bot commented May 13, 2023

ehei commented May 13, 2023

Boostrix commented May 15, 2023

ehei commented May 15, 2023 via email

gravelBridge commented May 16, 2023

ehei commented May 23, 2023

ehei commented Apr 19, 2023 •

edited

Loading

Pwuts commented Apr 22, 2023 •

edited

Loading

codecov bot commented Apr 24, 2023 •

edited

Loading