Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Python 3.10 & improve CI workflow #2369

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Move to Python 3.10 & improve CI workflow #2369

merged 4 commits into from
Apr 18, 2023

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Apr 18, 2023 •
edited
Loading

Background

CI workflow was updated but now runs twice. Also runs with Python 3.8 which is inconsistent with README (#2342). Python version in other places is also inconsistent.

pull_request_target is both risky and unnecessary: CI will already run on push in the fork.

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@Pwuts Pwuts force-pushed the ci/improve-workflow branch from 13a1254 to cf34e5d Compare April 18, 2023 12:07
@Pwuts Pwuts requested a review from Torantulino April 18, 2023 13:02
@Pwuts Pwuts linked an issue Apr 18, 2023 that may be closed by this pull request
Update CI to require python 3.10 #2342
Closed
1 task
@ntindle ntindle mentioned this pull request Apr 18, 2023
Closed
5 tasks
@aperullo
Copy link

Related: #2267

@Androbin
Copy link
Contributor

Don't forget to update .github/workflows/benchmark.yml and .devcontainer/Dockerfile, see #2107

@Pwuts Pwuts changed the title ci: move to Python 3.10 & improve workflow Move to Python 3.10 & improve CI workflow Apr 18, 2023
@Pwuts Pwuts added docker ci and removed docker labels Apr 18, 2023
@ntindle
Copy link
Member

ntindle commented Apr 18, 2023

PR for #2424 pt 1: "shirt sizing" is ready pending this pull request being merged into master on Pwuts/Auto-GPT/tree/ci/shirt-sizing

@Pwuts Pwuts requested a review from BillSchumacher April 18, 2023 23:23
@Pwuts Pwuts merged commit e2accab into Significant-Gravitas:master Apr 18, 2023
@Pwuts Pwuts deleted the ci/improve-workflow branch April 18, 2023 23:27
@Androbin Androbin mentioned this pull request Apr 19, 2023
Closed
5 tasks
@Pwuts Pwuts mentioned this pull request May 22, 2023
Closed
5 tasks
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
@Pwuts
Move to Python 3.10 & improve CI workflow (Significant-Gravitas#2369)
b33daf7 
* Use Python 3.10 in CI, benchmark, devcontainer, docker config, .sourcery.yaml
* Improve Python CI workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle left review comments

@BillSchumacher BillSchumacher BillSchumacher approved these changes

@Torantulino Torantulino Awaiting requested review from Torantulino

Assignees
No one assigned
Labels
ci
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI to require python 3.10
5 participants
@Pwuts @aperullo @Androbin @ntindle @BillSchumacher