Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #1211 - gpt-3.5 chunk is less than the default #2324

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix Issue #1211 - gpt-3.5 chunk is less than the default #2324

merged 1 commit into from
Apr 19, 2023

Conversation

itaihochman
Copy link

@itaihochman itaihochman commented Apr 18, 2023 •
edited
Loading

Fix Issue #1211 - gpt-3.5 chunk is 4096 but the default of the split is 8192
Add an option to set the chunk size using the configuration - BROWSE_CHUNK_MAX_LENGTH=4000
This way, we can avoid errors of exceeding chunk size when using gpt-3.5

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

Add an option to set the chunk size using the
e34ede7 
configoration - BROWSE_CHUNK_MAX_LENGTH=4000
This way, we can avoid errors of exceeding chunk size when using gpt-3.5
@nponeccop nponeccop added bug Something isn't working B8 labels Apr 19, 2023
@Pwuts
Copy link
Member

Pwuts commented Apr 19, 2023

This is a tempfix. Should be improved upon when we have time: #2541

@Pwuts Pwuts merged commit d9cb000 into Significant-Gravitas:master Apr 19, 2023
@itaihochman itaihochman deleted the iss1211 branch April 19, 2023 15:37
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
@Pwuts
Merge pull request Significant-Gravitas#2324 from itaihochman/iss1211
a635def 
* Use BROWSE_MAX_CHUNK_LENGTH for chunking text
* Fix Issue Significant-Gravitas#1211: GPT-3.5 token limit is lower than the default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts approved these changes

@nponeccop nponeccop nponeccop approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itaihochman @Pwuts @nponeccop