Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements-docker.txt #2024

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

deece
Copy link
Contributor

@deece deece commented Apr 16, 2023

Background

This file needs to be maintained parallel to requirements.txt, but isn't, causes problems when new dependencies are introduced.

Instead, derive the Docker dependencies from the stock ones.

Changes

Remove the docker requirements file
Add a flag comment to requirements.txt
Update Dockerfile to remove content after the flag comment

Documentation

The flag comment in requirements.txt explains that content after it will be ignored for Docker

Test Plan

Rebuilt the docker image and confirmed autogpt executed and performed initial prompt processing

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@deece deece mentioned this pull request Apr 17, 2023
5 tasks
@richbeales
Copy link
Contributor

please fix the conflicts and then this can go in

This file needs to be maintained parallel to requirements.txt, but
isn't, causes problems when new dependencies are introduced.

Instead, derive the Docker dependencies from the stock ones.

Signed-off-by: Alastair D'Silva <[email protected]>
@deece
Copy link
Contributor Author

deece commented Apr 17, 2023

@richbeales Done :)

@nponeccop nponeccop added the B8 label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants