Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hotfix user input #2019

Merged

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Apr 16, 2023

Background

hotfix

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@waynehamadi waynehamadi force-pushed the feature/hotfix-user_input branch from 40fdc1b to a9167a1 Compare April 16, 2023 22:32
@p-i- p-i- merged commit 1513be4 into Significant-Gravitas:master Apr 16, 2023
@alexonab
Copy link
Contributor

Was user input renamed to triggering_prompt?

user_input = self.triggering_prompt

@waynehamadi
Copy link
Contributor Author

waynehamadi commented Apr 16, 2023

no, self.user_input was wrongfully overwritten by human feedback and other user input.

but self.user_input was actually the triggering prompt, it had an incorrect name

so self.user_input was renamed self.triggering prompt.

and in the place where we were overwriting the self.user_input we know use the user_input variable.

@waynehamadi
Copy link
Contributor Author

waynehamadi commented Apr 16, 2023

there was a hotfix a few minutes ago, pull master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants