Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update run_continuous.sh to correctly pass all command-line arguments #2012

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Conversation

0xf333
Copy link
Contributor

@0xf333 0xf333 commented Apr 16, 2023

Background

This pull request aims to improve the usability of the run_continuous.sh script by ensuring that all command-line arguments are passed through to the run.sh script and the autogpt module. The original implementation did not properly pass additional command-line arguments, which could lead to confusion and limited flexibility for users.

Changes

  • Modified run_continuous.sh to include the --continuous flag directly in the command:
    • Removed the unused argument variable.
    • Added the --continuous flag to the ./run.sh command.
    • Ensured all command-line arguments are passed through to run.sh and the autogpt module.

Documentation

The changes made are documented here

Test Plan

  1. Tested the run_continuous.sh script on a Linux system with various command-line arguments.
  2. Verified that the --continuous flag was added to the command-line arguments when running the script.
  3. Confirmed that all additional command-line arguments were passed through to the run.sh script and the autogpt module.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

Description:

- Modified `run_continuous.sh` to include the `--continuous` flag directly in the command:
  - Removed the unused `argument` variable.
  - Added the `--continuous` flag to the `./run.sh` command.
  - Ensured all command-line arguments are passed through to `run.sh` and the `autogpt` module.

This change improves the usability of the `run_continuous.sh` script by allowing users to provide
additional command-line arguments along with the `--continuous` flag. It ensures that all arguments
are properly passed to the `run.sh` script and eventually to the `autogpt` module, preventing
confusion and providing more flexible usage.

Suggestion from:
#1941 (comment)
@0xf333
Copy link
Contributor Author

0xf333 commented Apr 16, 2023

@nponeccop
Here is the requested change

0xf333 and others added 4 commits April 16, 2023 17:57
Description:
Per maintainer's request, removed quotes around `$@` in `run_continuous.sh`.
This change allows the script to forward arguments as is. Please note that
this modification might cause issues if any of the command-line arguments
contain spaces or special characters. However, this update aligns with the
preferred format for the repository.

Suggestion from:
#1941 (comment)
@richbeales richbeales merged commit eefbccd into Significant-Gravitas:master Apr 17, 2023
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
Fix: Update run_continuous.sh to correctly pass all command-line arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants