Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
web_requests.py
module attempts to identify if a document is internal or not. There are a few ways to bypass these. A common attack for access internal resources is SSRF. More information can be found here: https://github.com/swisskyrepo/PayloadsAllTheThings/blob/master/Server%20Side%20Request%20Forgery/README.mdChanges
I added a few extra items to the list for checking to see if the program is access internal resources. The
startswith()
function only checks the first part of the string, which could disallow legitimate domains too likehttp://localhost.something.com
. The biggest change was to add '127.0.0.1' as a localhost.Documentation
I didn't add any comments, as I can imagine this might just add clutter to the overall program itself, with everyone commenting little changes like this.
Test Plan
I wrote a list of internal links and attempted to access them and found that they were not caught.
PR Quality Checklist