fixes Weaviate index name to classname conversion #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nponeccop
approved these changes
Apr 16, 2023
|
Indicate that it's weaviate in the title |
cs0lar
changed the title
richbeales
approved these changes
Apr 17, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…_index_to_classname fixes Weaviate index name to classname conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
It fixes an issue in the Weaviate integration whereby if a lowercase index name is specified in the MEMORY_INDEX environment variable it will raise a key error when processing Weaviate results
Changes
Added static function that replicates the converrsion from index name to classname that the Weaviate python client uses.
Documentation
A note about the conversion is made in code comment form for the
format_classnamestatic method.Test Plan
The current tests have been updated to reflect the conversion from indexname to classname.
PR Quality Checklist