Ensure Python 3.10 & 3.11 compatability #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
changed the title
nponeccop
previously approved these changes
Apr 16, 2023
I'm not entirely sure if it actually slows down the review process. Aren't the jobs run in parallel? Is there an easy way to check this? |
|
They are but there is concurrency limit. I guess with merge queues the impact will be smaller. So it's discussible. |
drikusroor
force-pushed
the
ensure-python-compatability
branch
from
33faea0 to
c6ce39a
Compare
drikusroor
changed the title
|
Don't forget to update |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Pwuts
force-pushed
the
ensure-python-compatability
branch
from
995ee0a to
b8db87f
Compare
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
conflicts
Pwuts
force-pushed
the
ensure-python-compatability
branch
from
b8db87f to
7f6febf
Compare
Pwuts
approved these changes
Apr 18, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
CI: Ensure compatability with Python 3.10 & 3.11 --------- Co-authored-by: Reinier van der Leer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The requirements section of
README.mdsays this project requires Python 3.8 or higher. Let's make sure that this is at least reflected in the CI.Changes
ci.ymlDocumentation
The documentation already said the requirements are "Python 3.8 or higher", and this is now also reflected in
ci.yml.Test Plan
The CI should succeed for all configured Python versions.
PR Quality Checklist