New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing tests to fit latest merges into master #1722

Merged

p-i- merged 2 commits into Significant-Gravitas:master from coditamar:fix_tests

Apr 15, 2023

Contributor

coditamar commented Apr 15, 2023

Background

Many approved PR lately. Broke 5 test files

Changes

Fixing the following tests files:
tests/local_cache_test.py
tests/smoke_test.py
tests/unit/test_browse_scrape_links.py
tests/unit/test_browse_scrape_text.py
tests/unit/test_commands.py
Adding pytest to requirements.txt

Documentation

N/A

Test Plan

Added tests. Didn't change code. In any case, I've run some prompts

PR Quality Checklist

My pull request is atomic and focuses on a single change.
I have thoroughly tested my changes with multiple different prompts.
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes

coditamar added 2 commits

April 16, 2023 00:42


          fixing tests to fit latest merges into master

14ac6ac


          Merge branch 'master' into fix_tests

d8d443d

Contributor

BillSchumacher commented Apr 15, 2023

lgtm

p-i- approved these changes

View reviewed changes

p-i- merged commit 5a87000 into Significant-Gravitas:master

coditamar deleted the fix_tests branch

April 15, 2023 22:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet