Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_ingestion.py 'no module named 'autogpt'" fix and ReadMe update #1679

Merged
merged 12 commits into from
Apr 16, 2023
Merged

data_ingestion.py 'no module named 'autogpt'" fix and ReadMe update #1679

merged 12 commits into from
Apr 16, 2023

Conversation

Slowly-Grokking
Copy link
Contributor

@Slowly-Grokking Slowly-Grokking commented Apr 15, 2023 •
edited
Loading

I relocated data_ingestion.py to the root folder to avoid sys.path or any changes to the code.
solves import from autogpt module.

#1671
#1667
#1577
#1401

Updated ReadMe accordingly
#1518 did not fix the code.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

This was referenced Apr 15, 2023
Merged
Closed
Closed
@Slowly-Grokking Slowly-Grokking changed the title data_ingestion.py fix --relocated data_ingestion.py 'no module named 'autogpt'" fix and ReadMe update Apr 15, 2023
This was referenced Apr 15, 2023
Closed
Closed
christian-gheorghe
christian-gheorghe previously approved these changes Apr 16, 2023
View reviewed changes
Copy link

@christian-gheorghe christian-gheorghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix!

@p-i-
Copy link
Contributor

p-i- commented Apr 16, 2023

@Slowly-Grokking Nice clean PR, thanks for researching/collating issues.
Could you possibly fix merge conflicts?

@nponeccop nponeccop added the B7 label Apr 16, 2023
@Slowly-Grokking
Copy link
Contributor Author

@Slowly-Grokking Nice clean PR, thanks for researching/collating issues. Could you possibly fix merge conflicts?

Thanks and no prob. Y'all seem to have resolved things before I got back, but I'll try to keep a look out.

@Slowly-Grokking Slowly-Grokking mentioned this pull request Apr 16, 2023
Closed
2 tasks
@richbeales richbeales merged commit 7d9269e into Significant-Gravitas:master Apr 16, 2023
@nponeccop nponeccop mentioned this pull request Apr 17, 2023
Closed
1 task
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
@richbeales
Merge pull request Significant-Gravitas#1679 from Slowly-Grokking/master
7e4d691 
data_ingestion.py 'no module named 'autogpt'" fix and ReadMe update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-i- p-i- p-i- approved these changes

@nponeccop nponeccop nponeccop approved these changes

@christian-gheorghe christian-gheorghe christian-gheorghe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Slowly-Grokking @p-i- @nponeccop @christian-gheorghe @richbeales