Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sourcery from docker build #1579

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

bufo24
Copy link
Contributor

@bufo24 bufo24 commented Apr 15, 2023

Background

I was unable to build the Dockerfile on my M1 Mac. This is due to the sourcery dependency in Python, this is not compatible with aarch64 and also not used while using autogpt, only for pre-commit checks and CI. Therefore I created another requirements file which does not have that dependency, so it will build on multiple CPU architectures.

Changes

Created another requirements file which excluded sourcery because it is not compatible with all architectures and also not using in the application itself.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@bufo24
Copy link
Contributor Author

bufo24 commented Apr 15, 2023

Please merge

@nponeccop
Copy link
Contributor

@richbeales is on his way

@richbeales richbeales merged commit 5bc7304 into Significant-Gravitas:master Apr 15, 2023
@nponeccop nponeccop mentioned this pull request Apr 15, 2023
1 task
@mikekelly
Copy link
Contributor

@richbeales I think, rather than doing it this way, it would be better to introduce an additional requirements file for pre-commit checks and CI. Otherwise the docker setup is a special case and whenever a dependency is added in requirements.txt someone needs to remember to add it to docker-requirements.txt.

What do you think?

sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants