Document function get_memory in autogpt.memory.vector #1296
Conversation
Document function get_memory in ./scripts/memory/init.py Background def get_memory was not documented. Now it is. Documentation helps greatly some developers, when they can move the pointer over a function and read exactly what it does. Changes Documentation
|
Sorry for the noob question but is my redis stack server / cotainer working properly when it shows this all the time : 2023-04-14 19:42:21 42:C 14 Apr 2023 17:42:21.019 * DB saved on disk Seems like its not storing any data? |
|
Hi. Replying to the Redis question. It works. Nothing to worry about. This is overhead memory indicator. This is an ideal number |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
3 similar comments
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
There was a problem hiding this comment.
This is a small, useful, atomic change that adds value.
Approved.
If it is not passing lint, make sure it does before merging.
I am not worried about the nit on spacing. If you can make that work while it continues to pass linting stuff that's great. If you can't get it to play nice with the linter with the suggested changes, just merge it where it passes the lint check.
Thanks for the contribution!
|
Also, conflicts etc |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
✅ Deploy Preview for auto-gpt-docs canceled.
|
Pwuts
changed the title
…ignificant-Gravitas#1296) * Document function get_memory in ./scripts/memory/init.py * Update get_memory docstring to current format --------- Co-authored-by: Reinier van der Leer <[email protected]>
Document function get_memory in ./scripts/memory/init.py
Background
def get_memory was not documented. Now it is.
Documentation helps greatly some developers, when they can move the pointer over a function and read exactly what it does.
Changes
Just Documentation
PR Quality Checklist