Cleanup azure parameters in env.template and remove unused env in config.py #1269
+4
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richbeales @sweetlilmre please take a look thanks. |
suensummit
force-pushed
the
cleanup-unused-azure-env
branch
from
e043c85 to
0ff1f1c
Compare
|
conflicts resolved, please review while available, thanks @nponeccop @sweetlilmre @richbeales @Torantulino |
|
@suensummit There are conflicts again |
…fig.load_azure_config().
suensummit
force-pushed
the
cleanup-unused-azure-env
branch
from
0ff1f1c to
a0de386
Compare
Resolved |
nponeccop
approved these changes
Apr 15, 2023
richbeales
approved these changes
Apr 15, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…unused-azure-env Cleanup azure parameters in env.template and remove unused env in config.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There are some unused azure environment variables left in the
env.templateas they are already moved toazure.yaml.template.Changes
env.template.config.py, also fix the yaml loader syntax with some preset values.Documentation
There are notes in
env.templateand the codes inconfig.pyis clear enough.Test Plan
Tested with azure configurations.
PR Quality Checklist