Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure backend/poetry.lock is always compatible/up-to-date with autogpt_libs dependencies #8884

Closed
Pwuts opened this issue Dec 5, 2024 — with Linear · 1 comment
Closed

Ensure backend/poetry.lock is always compatible/up-to-date with autogpt_libs dependencies #8884

Pwuts opened this issue Dec 5, 2024 — with Linear · 1 comment
Assignees
@Pwuts
Labels
ci DX

Comments

@Pwuts Linear
Copy link
Member

Pwuts commented Dec 5, 2024

Dependabot managed to update pydantic to a version that causes type error(s) in our codebase:

image.png

No overloads for "Field" match the provided arguments
  Argument types: (T@SchemaField | PydanticUndefinedType, *tuple[Unknown, ...], (() -> T@SchemaField) | None, str | None, str | None, bool, dict[str, Unknown], **dict[str, Unknown])

This passed CI because we don't check backend/poetry.lock against autogpt_libs's dependencies' version requirements.
@Pwuts Pwuts added ci DX labels Dec 5, 2024 — with Linear
@Pwuts Pwuts self-assigned this Dec 5, 2024
@Pwuts Pwuts mentioned this issue Dec 5, 2024
Merged
@Pwuts Linear
Copy link
Member Author

Pwuts commented Dec 5, 2024 •
edited
Loading

Also reported the underlying issue to Pydantic:

github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024
@Pwuts
ci(backend): Add poetry.lock check (#8885)
0272d87 
- Resolves #8884

We need to prevent breaking updates to dependency version requirements
of `autogpt_libs`.
`autogpt_libs/pytroject.toml` and `backend/poetry.lock` are loosely
coupled, and to ensure they stay in sync we need an extra check.

For now I'm also reverting the breaking update of #8787, otherwise this
added CI check will immediately fail.

### Changes
- ci(backend): Add `poetry.lock` check
- Revert "build(deps): bump pydantic from 2.9.2 to 2.10.2 in
/autogpt_platform/autogpt_libs in the production-dependencies group
across 1 directory (#8787)"
@Pwuts Pwuts closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pwuts Pwuts

Labels
ci DX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pwuts