Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement status indicator for webhook-triggered nodes #8743

Closed
Tracked by #8358
Pwuts opened this issue Nov 21, 2024 — with Linear · 0 comments
Closed
Tracked by #8358

Implement status indicator for webhook-triggered nodes #8743

Pwuts opened this issue Nov 21, 2024 — with Linear · 0 comments
Assignees
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end

Comments

Copy link
Member

Pwuts commented Nov 21, 2024

Implement an indicator for whether a webhook-triggered node is "active" (= webhook is set up and the node is linked to it). A ping endpoint that may be of use for this is already implemented in the REST API.

@Pwuts Pwuts added platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end labels Nov 21, 2024 — with Linear
@Pwuts Pwuts self-assigned this Nov 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024
- Resolves #8743
- Follow-up to #8358

### Demo


https://github.com/user-attachments/assets/f983dfa2-2dc2-4ab0-8373-e768ba17e6f7

### Changes 🏗️

- feat(frontend): Add webhook status indicator on `CustomNode`
   - Add `webhookId` to frontend node data model

- fix(backend): Fix webhook ping endpoint
   - Remove `provider` path parameter
   - Fix return values and error handling
   - Fix `WebhooksManager.trigger_ping(..)`
      - Add `credentials` parameter
      - Fix usage of credentials
   - Fix `.data.integrations.wait_for_webhook_event(..)`
      - Add `AsyncRedisEventBus.wait_for_event(..)`

- feat(frontend): Add `BackendAPIProvider` + `useBackendAPI`

- feat(frontend): Improve layout of node header

    Before:

![image](https://github.com/user-attachments/assets/17a33b94-65f0-4e34-a47d-2dd321edecae)
    After:

![image](https://github.com/user-attachments/assets/64afb1e4-e3f2-4ca9-8961-f1245f25477f)

- refactor(backend): Clean up `.data.integrations`
- refactor(backend): Fix naming in `.data.queue` for understandability

### Checklist 📋

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->
  - [x] Add webhook block, save -> gray indicator
  - [x] Add necessary info to webhook block, save -> green indicator
  - [x] Remove necessary info, save -> gray indicator

---------

Co-authored-by: Nicholas Tindle <[email protected]>
@Pwuts Pwuts closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end
Projects
None yet
Development

No branches or pull requests

1 participant