Bump rubocop-shopify from 2.1.0 to 2.4.0 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
To get CI to pass, I had to upgrade |
vinistock
force-pushed
the
dependabot/bundler/rubocop-shopify-2.4.0
branch
from
75d9d6c to
60f352c
Compare
KaanOzkan
approved these changes
Feb 1, 2022
| @@ -16,6 +16,10 @@ AllCops: | |||
| Include: | |||
| - "sorbet/rbi/**/*.rbi" | |||
|
|
|||
| Naming/InclusiveLanguage: | |||
| Exclude: | |||
| - "lib/tapioca/compilers/dsl/protobuf.rb" | |||
There was a problem hiding this comment.
Is this because of usage of master?
There was a problem hiding this comment.
Yes - we can't control the URL used in the docs. Also, I can't use the rubocop:disable comment, otherwise that will show up in our docs, so I just turned it off for the file.
Bumps [rubocop-shopify](https://github.com/Shopify/ruby-style-guide) from 2.1.0 to 2.4.0. - [Release notes](https://github.com/Shopify/ruby-style-guide/releases) - [Commits](Shopify/ruby-style-guide@v2.1.0...v2.4.0) --- updated-dependencies: - dependency-name: rubocop-shopify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
RyanBrushett
approved these changes
Feb 1, 2022
vinistock
force-pushed
the
dependabot/bundler/rubocop-shopify-2.4.0
branch
from
60f352c to
790d306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-shopify from 2.1.0 to 2.4.0.
Release notes
Sourced from rubocop-shopify's releases.
Commits
5bf6961Prepare for 2.4.0f0c9f96Require rubocop 1.245856e7aMerge pull request #345 from Shopify/dependabot/bundler/rubocop-1.24.16807259Update the configuration for 1.24.1abc2b38Merge pull request #344 from Shopify/dependabot/npm_and_yarn/eslint-plugin-pr...93ca4efMerge pull request #343 from Shopify/dependabot/npm_and_yarn/sass-1.45.237335c6Merge pull request #342 from Shopify/dependabot/github_actions/actions/setup-...013d3faMerge pull request #340 from Shopify/dependabot/bundler/minitest-5.15.0d6a2bf2Bump rubocop from 1.23.0 to 1.24.107a288bBump eslint-plugin-promise from 5.2.0 to 6.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)